Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expiring links to S3 resources should be generated on click instead of page load #91

Open
rocketeerbkw opened this issue Dec 13, 2022 · 0 comments

Comments

@rocketeerbkw
Copy link
Member

There are a few places in the api/ui where Lagoon stores and retrieves files. Currently these are environment backups, task files and insights. The files are retrieved directly from S3 using a signed/short-lived link, meaning no Lagoon authorization is performed once a link is generated. The current system generates a link on page load valid for 5 minutes, in order to account for time that a user might be doing other tasks in between the page load and them clicking the link.

By moving the link generation from the page load to the moment they click the link, that would allow us to shorten the time a link is valid to reduce the risk of unauthorized access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant