Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Link Redirect System #1030

Closed
Schnitzel opened this issue Apr 4, 2019 · 6 comments
Closed

S3 Link Redirect System #1030

Schnitzel opened this issue Apr 4, 2019 · 6 comments
Assignees

Comments

@Schnitzel
Copy link
Contributor

This is a follow up for #999

Currently the link shown in the Lagoon UI is directly linking to S3.
With the work done in this ticket, the link will point to a Lagoon UI URL, which will create a redirect to the S3 bucket with a validity of 5 seconds.

@bomoko
Copy link
Contributor

bomoko commented Dec 5, 2022

After a quick DX chat, we're questioning whether this will work for all cases (without having some kind of fallback functionality). Needs to be discussed in more depth.

The lagoon-cli might also complicate this.

@shreddedbacon
Copy link
Member

Just because I saw this was recently updated. The ability to do custom restore locations could also add some complications to the mix.

@tobybellwood
Copy link
Member

tobybellwood commented Dec 12, 2022

Current status (for clarification) - the download link in the UI is valid for 5 minutes, is signed by the file host, and is available to anyone who has been shared that link.

@tobybellwood
Copy link
Member

Proposed solution - reduce the timeout to 1 minute, but start the timer on the click of the download button instead of the page load.

@seanhamlin
Copy link
Contributor

Some customers do use the direct S3 link to download the backup into a pod for example. So being able to access the raw signed URL would be ace. Having a 1 minute validity will be OK.

@rocketeerbkw
Copy link
Member

Created follow up issues #3367 uselagoon/lagoon-ui#91 uselagoon/lagoon-ui#92

@rocketeerbkw rocketeerbkw closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants