Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the expiring time of S3 links to be configurable #3367

Open
rocketeerbkw opened this issue Dec 13, 2022 · 0 comments
Open

Allow the expiring time of S3 links to be configurable #3367

rocketeerbkw opened this issue Dec 13, 2022 · 0 comments
Labels
1-api-auth API & Authentication subsystem

Comments

@rocketeerbkw
Copy link
Member

There are a few places in the api/ui where Lagoon stores and retrieves files. Currently these are environment backups, task files and insights. The files are retrieved directly from S3 using a signed/short-lived link, meaning no Lagoon authorization is performed once a link is generated. The current system generates a link valid for 5 minutes.

If we make improvements to the UI, we should be able to shorten the time links are valid by quite a bit. In order to prepare for that, and to allow Lagoon users to decide for themselves how long it should be, we can move the currently hardcoded expire time to an environment variable.

@rocketeerbkw rocketeerbkw added the 1-api-auth API & Authentication subsystem label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-api-auth API & Authentication subsystem
Projects
None yet
Development

No branches or pull requests

1 participant