Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove kube-rbac-proxy from lagoon-build-deploy #704

Merged
merged 1 commit into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions charts/lagoon-build-deploy/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ kubeVersion: ">= 1.25.0-0"

type: application

version: 0.30.3
version: 0.31.0

appVersion: v0.20.3
appVersion: v0.21.0

annotations:
artifacthub.io/changes: |
- kind: changed
description: update controller to v0.20.3
description: update controller to v0.21.0
artifacthub.io/crds: |
- kind: LagoonBuild
version: v1beta2
Expand Down
23 changes: 4 additions & 19 deletions charts/lagoon-build-deploy/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,6 @@ spec:
securityContext:
{{- toYaml .Values.podSecurityContext | nindent 8 }}
containers:
- name: kube-rbac-proxy
securityContext:
{{- toYaml .Values.kubeRBACProxy.securityContext | nindent 10 }}
image: "{{ .Values.kubeRBACProxy.image.repository }}:{{ .Values.kubeRBACProxy.image.tag }}"
imagePullPolicy: {{ .Values.kubeRBACProxy.image.pullPolicy }}
args:
- "--secure-listen-address=0.0.0.0:8443"
- "--upstream=http://127.0.0.1:8080/"
- "--logtostderr=true"
- "--v=10"
ports:
- containerPort: 8443
name: https
resources:
{{- toYaml .Values.kubeRBACProxy.resources | nindent 10 }}
- name: manager
securityContext:
{{- toYaml .Values.securityContext | nindent 10 }}
Expand All @@ -48,11 +33,11 @@ spec:
command:
- /manager
ports:
- containerPort: 9912
name: metrics
- containerPort: 8443
name: https
args:
- "--metrics-addr=127.0.0.1:8080"
- "--enable-leader-election=true"
- "--metrics-bind-address=:8443"
- "--leader-elect=true"
{{- if .Values.harbor.enabled }}
- "--enable-harbor=true"
- "--harbor-password={{ .Values.harbor.adminPassword }}"
Expand Down
15 changes: 0 additions & 15 deletions charts/lagoon-build-deploy/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,3 @@ spec:
name: https
selector:
{{- include "lagoon-build-deploy.selectorLabels" . | nindent 4 }}
---
kind: Service
apiVersion: v1
metadata:
name: {{ include "lagoon-build-deploy.fullname" . }}-metrics
labels:
{{- include "lagoon-build-deploy.labels" . | nindent 4 }}
spec:
ports:
- name: metrics
protocol: TCP
port: 9912
targetPort: metrics
selector:
{{- include "lagoon-build-deploy.selectorLabels" . | nindent 4 }}
2 changes: 1 addition & 1 deletion charts/lagoon-build-deploy/templates/servicemonitor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ metadata:
spec:
endpoints:
- interval: {{ .Values.metrics.interval }}
port: metrics
port: https
namespaceSelector:
matchNames:
- lagoon
Expand Down
11 changes: 0 additions & 11 deletions charts/lagoon-build-deploy/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -196,14 +196,3 @@ nodeSelector: {}
tolerations: []

affinity: {}

# this is a sidecar in the same pod as the lagoonBuildDeploy container
kubeRBACProxy:
image:
repository: gcr.io/kubebuilder/kube-rbac-proxy
pullPolicy: IfNotPresent
tag: v0.4.1

securityContext: {}

resources: {}
Loading