Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove kube-rbac-proxy from lagoon-build-deploy #704

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Dec 1, 2024

Updates the lagoon-build-deploy chart to support the removal of the kube-rbac-proxy from the remote-controller uselagoon/remote-controller#272

@shreddedbacon shreddedbacon force-pushed the remove-kube-rbac-proxy branch 4 times, most recently from b3f1565 to 74c8674 Compare December 4, 2024 07:06
@shreddedbacon shreddedbacon force-pushed the remove-kube-rbac-proxy branch 2 times, most recently from da46c61 to 58ef5a0 Compare December 18, 2024 01:48
@shreddedbacon shreddedbacon marked this pull request as ready for review December 18, 2024 02:27
@shreddedbacon shreddedbacon added this to the core-v2.23.0 milestone Dec 18, 2024
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, unnecessary service removed ok!

@tobybellwood tobybellwood merged commit e405f6d into main Dec 18, 2024
18 checks passed
@tobybellwood tobybellwood deleted the remove-kube-rbac-proxy branch December 18, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants