Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run "up login" with the UP_TOKEN environment and a PAT instead of "up login -u" #190

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

ulucinar
Copy link
Contributor

@ulucinar ulucinar commented Mar 7, 2024

Description of your changes

This PR switches to PAT credentials in the publish-service-artifacts workflow from user credentials for the up login command. The session token then authenticates the workflow against the Upbound registry to push the family provider packages.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

The command and its environment have been tested on my local machine.

@ulucinar ulucinar requested a review from sergenyalcin as a code owner March 7, 2024 16:26
Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@ulucinar ulucinar merged commit dc5d6f3 into upbound:main Mar 7, 2024
6 checks passed
@ulucinar ulucinar deleted the up-login branch March 7, 2024 16:30
ulucinar added a commit that referenced this pull request Mar 12, 2024
[Backport standard-runners]: Backports PRs #187 #188 #189 #190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants