-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport standard-runners]: Backports PRs #187 #188 #189 #190 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omment-trigger & provider-ci reusable workflows Signed-off-by: Alper Rifat Ulucinar <[email protected]> (cherry picked from commit fa17907)
- buildtagger can be used to generate the desired build tags (constraints) for the official provider families. - Each resource provider's source modules can share a unique build tag so that tag-aware Go tools (including golangci-lint) can load only those source modules. Signed-off-by: Alper Rifat Ulucinar <[email protected]> (cherry picked from commit f069865)
Signed-off-by: Alper Rifat Ulucinar <[email protected]> (cherry picked from commit df38579)
Signed-off-by: Alper Rifat Ulucinar <[email protected]> (cherry picked from commit 73dcf55)
… exit non-zero Signed-off-by: Alper Rifat Ulucinar <[email protected]> (cherry picked from commit 032f662)
Signed-off-by: Alper Rifat Ulucinar <[email protected]> (cherry picked from commit a467b51)
Signed-off-by: Alper Rifat Ulucinar <[email protected]> (cherry picked from commit 574bdd3)
Signed-off-by: Alper Rifat Ulucinar <[email protected]> (cherry picked from commit ed0270f)
…w to conditionally skip the "lint" job. Signed-off-by: Alper Rifat Ulucinar <[email protected]> (cherry picked from commit 790ea72)
…exity Signed-off-by: Alper Rifat Ulucinar <[email protected]> (cherry picked from commit e05c869)
Signed-off-by: Sergen Yalçın <[email protected]> (cherry picked from commit 2d89b1e)
… login -u" Signed-off-by: Alper Rifat Ulucinar <[email protected]> (cherry picked from commit 37ae29b)
sergenyalcin
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ulucinar LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Backports PRs #187 #188 #189 #190 to the
standard-runners
branch. We will be maintaining this branch until #135 is merged (being able to pass only hosted runner labels as the parameter values poses a serious limitation to this approach, especially if we also have OCI runners).I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Following diff is the diff between this PR's feature branch & head of
upstream/main
: