Instructor Permissions Tests: fetch DDAHs #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siefkenj
reviewed
May 23, 2021
alex-kozin
force-pushed
the
feat/test-instructor-permissions
branch
from
35157be
to
92aa8d6
Compare
alex-kozin
changed the title
alex-kozin
changed the title
alex-kozin
commented
May 29, 2021
Comment on lines
79
to
81
| const newDdah = { | ||
| assignment_id: assignments.payload[0].id, | ||
| duties: [ |
There was a problem hiding this comment.
We could alternatively pass this as a parameter, but I opted for hard-coding it here, so that the test itself is easier to read/understand
There was a problem hiding this comment.
Hard coding is fine. We'll change it if we need more functionality.
siefkenj
reviewed
May 29, 2021
Comment on lines
79
to
81
| const newDdah = { | ||
| assignment_id: assignments.payload[0].id, | ||
| duties: [ |
There was a problem hiding this comment.
Hard coding is fine. We'll change it if we need more functionality.
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First test for fetching DDAHs for instructor. Related to issue #597