Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructor permission test should also test correct data visibility #526

Open
Accelsnow opened this issue Mar 25, 2021 · 3 comments · Fixed by #588 or #599
Open

Instructor permission test should also test correct data visibility #526

Accelsnow opened this issue Mar 25, 2021 · 3 comments · Fixed by #588 or #599
Assignees
Labels
test Testing code

Comments

@Accelsnow
Copy link
Contributor

PR #477 is getting bloated; therefore this section will not be implemented in this PR. After this PR is merged a new PR will be created to implement tests for data visibility.

@Accelsnow Accelsnow self-assigned this Mar 25, 2021
@Accelsnow Accelsnow added the test Testing code label Mar 25, 2021
@alex-kozin
Copy link
Contributor

@siefkenj is there more context for this one? What data visibility are we talking about in the instructor permission tests?

@alex-kozin
Copy link
Contributor

Phone number should not be visible to instructors. Currently instructor is a restricted admin, i.e. they have the same init procedure, but get a subset of existing data. We need to go through some fields and see if they should be seen by instructors. After that we should write tests for these fields to be restricted.

@alex-kozin
Copy link
Contributor

alex-kozin commented Jul 5, 2021

FAS is worried about sessional instructors having permissions to see grad students, etc. Instructors should NOT see applications and see applicants.As a first iteration at least. We might want to let them do that still - TBD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Testing code
Projects
None yet
2 participants