Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Housecleaning #23

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Housecleaning #23

wants to merge 12 commits into from

Commits on Apr 13, 2020

  1. Add .editorconfig and fix minor formatting issues

    - missing whitespace
    - star-imports
    runeflobakk committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    9de2726 View commit details
    Browse the repository at this point in the history
  2. Fix javadoc errors, and use doclint

    The doclint is set to "all except missing tags". It's a reasonable
    setting to avoid having to add redundant noise for self-explanatory
    paramters, types and such.
    runeflobakk committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    54390c0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba74fec View commit details
    Browse the repository at this point in the history
  4. Upgrade all Maven plugins

    Use strictly pluginManagement for settings versions in order to be able
    to invoke single plugins and get the same version as specified in the
    build, as well as configuration.
    
    Executions, in addition to plugins part of the default (jar) lifecycle,
    are configured in build/plugins.
    
    Configure versions-maven-plugin to be able to check for newer
    dependencies/plugin versions
    
    Add maven-enforcer-plugin to set minimal Maven version required by
    configured plugins.
    runeflobakk committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    4780bae View commit details
    Browse the repository at this point in the history
  5. Upgade to JUnit 5 and Hamcrest 2.2

    Change tests to being package scoped, and remov unnecessary exception
    declarations.
    runeflobakk committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    9b5be5d View commit details
    Browse the repository at this point in the history
  6. Do not build test-jar

    runeflobakk committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    dfba3ca View commit details
    Browse the repository at this point in the history
  7. Deny unused declared & used but undeclared deps

    maven-dependency-plugin analyzes and failes the build if:
    - code is using a dependency which has been pulled in transitively, but
    not declared as a dependency. Code used is direct dependency, and must
    be declared as such.
    - a dependency has been declared, but the code is actually not using it.
    Thus, is can be removed (unless it is a runtime dependency, but the
    nature of this library makes this very unlikely).
    runeflobakk committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    5295067 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2020

  1. Build on Travis on OpenJDK 8

    oraclejdk8 only gives error:
    Expected feature release number in range of 9 to 15, but got: 8
    The command "~/bin/install-jdk.sh --target "/home/travis/oraclejdk8" --workspace "/home/travis/.cache/install-jdk" --feature "8" --license "BCL"" failed and exited with 3 during .
    
    Supposedly it is possible to use oraclejdk8 if forcing the dist on
    Travis to be "trusty", but it is EOL, so let's not start using something
    which is already deprecated and will eventually go away. OpenJDK works
    just fine.
    runeflobakk committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    1070dd7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    df49d2e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    91a644e View commit details
    Browse the repository at this point in the history
  4. Build using mvn verify

    Default build command on Travis is mvn test
    runeflobakk committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    c81bac7 View commit details
    Browse the repository at this point in the history
  5. Only do one build on Travis

    Travis' default behaviour is to first do mvn install without tests to
    "install" dependencies, and then execute a normal build with tests.
    This is to align with the build lifecycle defined by Travis, but it is
    not necessary for a Maven build, which should do everything it needs by
    executing the idiomatic mvn clean install.
    
    This should even further speed up the build.
    runeflobakk committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    a2b6a34 View commit details
    Browse the repository at this point in the history