This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Housecleaning #23
Open
runeflobakk
wants to merge
12
commits into
unruly:master
Choose a base branch
from
runeflobakk:project-housecleaning
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Housecleaning #23
Commits on Apr 13, 2020
-
Add .editorconfig and fix minor formatting issues
- missing whitespace - star-imports
Configuration menu - View commit details
-
Copy full SHA for 9de2726 - Browse repository at this point
Copy the full SHA 9de2726View commit details -
Fix javadoc errors, and use doclint
The doclint is set to "all except missing tags". It's a reasonable setting to avoid having to add redundant noise for self-explanatory paramters, types and such.
Configuration menu - View commit details
-
Copy full SHA for 54390c0 - Browse repository at this point
Copy the full SHA 54390c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba74fec - Browse repository at this point
Copy the full SHA ba74fecView commit details -
Use strictly pluginManagement for settings versions in order to be able to invoke single plugins and get the same version as specified in the build, as well as configuration. Executions, in addition to plugins part of the default (jar) lifecycle, are configured in build/plugins. Configure versions-maven-plugin to be able to check for newer dependencies/plugin versions Add maven-enforcer-plugin to set minimal Maven version required by configured plugins.
Configuration menu - View commit details
-
Copy full SHA for 4780bae - Browse repository at this point
Copy the full SHA 4780baeView commit details -
Upgade to JUnit 5 and Hamcrest 2.2
Change tests to being package scoped, and remov unnecessary exception declarations.
Configuration menu - View commit details
-
Copy full SHA for 9b5be5d - Browse repository at this point
Copy the full SHA 9b5be5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for dfba3ca - Browse repository at this point
Copy the full SHA dfba3caView commit details -
Deny unused declared & used but undeclared deps
maven-dependency-plugin analyzes and failes the build if: - code is using a dependency which has been pulled in transitively, but not declared as a dependency. Code used is direct dependency, and must be declared as such. - a dependency has been declared, but the code is actually not using it. Thus, is can be removed (unless it is a runtime dependency, but the nature of this library makes this very unlikely).
Configuration menu - View commit details
-
Copy full SHA for 5295067 - Browse repository at this point
Copy the full SHA 5295067View commit details
Commits on Apr 15, 2020
-
oraclejdk8 only gives error: Expected feature release number in range of 9 to 15, but got: 8 The command "~/bin/install-jdk.sh --target "/home/travis/oraclejdk8" --workspace "/home/travis/.cache/install-jdk" --feature "8" --license "BCL"" failed and exited with 3 during . Supposedly it is possible to use oraclejdk8 if forcing the dist on Travis to be "trusty", but it is EOL, so let's not start using something which is already deprecated and will eventually go away. OpenJDK works just fine.
Configuration menu - View commit details
-
Copy full SHA for 1070dd7 - Browse repository at this point
Copy the full SHA 1070dd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for df49d2e - Browse repository at this point
Copy the full SHA df49d2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 91a644e - Browse repository at this point
Copy the full SHA 91a644eView commit details -
Default build command on Travis is mvn test
Configuration menu - View commit details
-
Copy full SHA for c81bac7 - Browse repository at this point
Copy the full SHA c81bac7View commit details -
Travis' default behaviour is to first do mvn install without tests to "install" dependencies, and then execute a normal build with tests. This is to align with the build lifecycle defined by Travis, but it is not necessary for a Maven build, which should do everything it needs by executing the idiomatic mvn clean install. This should even further speed up the build.
Configuration menu - View commit details
-
Copy full SHA for a2b6a34 - Browse repository at this point
Copy the full SHA a2b6a34View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.