This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Housecleaning #23
Open
Housecleaning #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- missing whitespace - star-imports
The doclint is set to "all except missing tags". It's a reasonable setting to avoid having to add redundant noise for self-explanatory paramters, types and such.
Use strictly pluginManagement for settings versions in order to be able to invoke single plugins and get the same version as specified in the build, as well as configuration. Executions, in addition to plugins part of the default (jar) lifecycle, are configured in build/plugins. Configure versions-maven-plugin to be able to check for newer dependencies/plugin versions Add maven-enforcer-plugin to set minimal Maven version required by configured plugins.
Change tests to being package scoped, and remov unnecessary exception declarations.
maven-dependency-plugin analyzes and failes the build if: - code is using a dependency which has been pulled in transitively, but not declared as a dependency. Code used is direct dependency, and must be declared as such. - a dependency has been declared, but the code is actually not using it. Thus, is can be removed (unless it is a runtime dependency, but the nature of this library makes this very unlikely).
oraclejdk8 only gives error: Expected feature release number in range of 9 to 15, but got: 8 The command "~/bin/install-jdk.sh --target "/home/travis/oraclejdk8" --workspace "/home/travis/.cache/install-jdk" --feature "8" --license "BCL"" failed and exited with 3 during . Supposedly it is possible to use oraclejdk8 if forcing the dist on Travis to be "trusty", but it is EOL, so let's not start using something which is already deprecated and will eventually go away. OpenJDK works just fine.
Default build command on Travis is mvn test
Travis' default behaviour is to first do mvn install without tests to "install" dependencies, and then execute a normal build with tests. This is to align with the build lifecycle defined by Travis, but it is not necessary for a Maven build, which should do everything it needs by executing the idiomatic mvn clean install. This should even further speed up the build.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some housecleaning chores to bring the code base and pom.xml up to speed.