Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long line overflow #86

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Conversation

yoching
Copy link
Contributor

@yoching yoching commented Mar 28, 2024

Removing max-width: 100vw; from #workspace.view-mode_regular #workspace-content, then adding min-width: 0; to .page-content .columns .column seems to fix the undesired behavior of overflowing long lines.

However, the entire code area width becomes the width of --readable-column-width-medium.
Is this the desired behavior?

Screenshot 2024-03-28 at 17 27 17

Reasoning

The source of issue seems to be:

  • max-width: 100vw; of #workspace-content seems inherently unnecessary. (so should be removed)
  • .columns has flex-direction:row
  • .column, the child of .columns, extends beyond its parent (.columns)

This situation is similar to these known issues:

@yoching
Copy link
Contributor Author

yoching commented Mar 28, 2024

#73
#80

@hojberg
Copy link
Member

hojberg commented Mar 28, 2024

@yoching

Awesome! thank you for looking at this. I think this is the right approach and I've basically have come to realize that most usages of 100vw are not useful.

The code being the full width of the card seems like the right thing. Does it have a scroll inside the card?

@hojberg
Copy link
Member

hojberg commented Mar 28, 2024

@yoching I think this is basically ready to go—super grateful for this fix 🙏

@hojberg hojberg marked this pull request as ready for review March 28, 2024 21:34
@hojberg hojberg merged commit 60fc392 into unisonweb:main Mar 29, 2024
3 checks passed
@yoching yoching deleted the fix-long-line-overflow branch April 12, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants