Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Very long lines in the code view doesn't seem to respect the content width #73

Closed
hojberg opened this issue Nov 15, 2023 · 5 comments
Closed

Very long lines in the code view doesn't seem to respect the content width #73

hojberg opened this issue Nov 15, 2023 · 5 comments

Comments

@hojberg
Copy link
Member

hojberg commented Nov 15, 2023

Originally reported by Kyle Goertz
@kylegoetz
Copy link

kylegoetz commented Nov 15, 2023 •
edited
Loading

pretty printed version is

certificates.ca.hueBridge : '{Exception} SignedCert
  certificates.ca.hueBridge =
    do
      "-----BEGIN CERTIFICATE-----\nMIICMjCCAdigAwIBAgIUO7FSLbaxikuXAljzVaurLXWmFw4wCgYIKoZIzj0EAwIw\nOTELMAkGA1UEBhMCTkwxFDASBgNVBAoMC1BoaWxpcHMgSHVlMRQwEgYDVQQDDAty\nb290LWJyaWRnZTAiGA8yMDE3MDEwMTAwMDAwMFoYDzIwMzgwMTE5MDMxNDA3WjA5\nMQswCQYDVQQGEwJOTDEUMBIGA1UECgwLUGhpbGlwcyBIdWUxFDASBgNVBAMMC3Jv\nb3QtYnJpZGdlMFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEjNw2tx2AplOf9x86\naTdvEcL1FU65QDxziKvBpW9XXSIcibAeQiKxegpq8Exbr9v6LBnYbna2VcaK0G22\njOKkTqOBuTCBtjAPBgNVHRMBAf8EBTADAQH/MA4GA1UdDwEB/wQEAwIBhjAdBgNV\nHQ4EFgQUZ2ONTFrDT6o8ItRnKfqWKnHFGmQwdAYDVR0jBG0wa4AUZ2ONTFrDT6o8\nItRnKfqWKnHFGmShPaQ7MDkxCzAJBgNVBAYTAk5MMRQwEgYDVQQKDAtQaGlsaXBz\nIEh1ZTEUMBIGA1UEAwwLcm9vdC1icmlkZ2WCFDuxUi22sYpLlwJY81Wrqy11phcO\nMAoGCCqGSM49BAMCA0gAMEUCIEBYYEOsa07TH7E5MJnGw557lVkORgit2Rm1h3B2\nsFgDAiEA1Fj/C3AN5psFMjo0//mrQebo0eKd3aWRx+pQY08mk48=\n-----END CERTIFICATE-----"
        |> Text.toUtf8
        |> decodeCert
        |> Either.toException

@kylegoetz
Copy link

also opened at unisonweb/unison#4392

@hojberg
Copy link
Member Author

hojberg commented Nov 15, 2023

Another example: https://share.unison-lang.org/@rlmark/cloudDoodles/code/releases/1.0.0/latest/terms/assets/indexHtml

@yoching
Copy link
Contributor

yoching commented Dec 8, 2023 •
edited
Loading

It looks like this max-width: 100vw; for #workspace.view-mode_regular #workspace-content is inappropriate
https://github.com/unisonweb/ui-core/blob/main/src/css/code/workspace.css#L11

andreystepanov added a commit to andreystepanov/ui-core that referenced this issue Jan 25, 2024
@andreystepanov
Fixing issues with long literals (unisonweb#73)
00c9b18
andreystepanov added a commit to andreystepanov/ui-core that referenced this issue Jan 25, 2024
@andreystepanov
Fix: long lines and unnecessary scroll in code
1d26b10 
- Fixes unisonweb#72
- Fixes unisonweb#73
@andreystepanov andreystepanov mentioned this issue Jan 25, 2024
Closed
This was referenced Mar 26, 2024
Closed
Merged
@hojberg
Copy link
Member Author

hojberg commented Mar 29, 2024

Fixed by #86

@hojberg hojberg closed this as completed Mar 29, 2024
@andreystepanov andreystepanov mentioned this issue Mar 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: long lines and unnecessary scroll in code andreystepanov/ui-core
3 participants
@hojberg @yoching @kylegoetz