-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UNDERTOW-2412 / 2445 / 2449 / 2446 / 2436 / 2422 / 2444 / 2448] Backport fixes to 2.3.x #1687
Commits on Oct 11, 2024
-
[UNDERTOW-2412] Read stored json with default UTF-8 encoding
Signed-off-by: Flavia Rainone <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 17fd02a - Browse repository at this point
Copy the full SHA 17fd02aView commit details
Commits on Oct 16, 2024
-
[UNDERTOW-2445] Fix the CI by upgrading all instances of upload-artif…
…act and download-artifact actions to v4 Signed-off-by: Flavia Rainone <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 69d8866 - Browse repository at this point
Copy the full SHA 69d8866View commit details -
[UNDERTOW-2449] Fix PushResourceRSTTestCase by shutting down writes a…
…nd adding a response listener only after push resource has been handled by the listener This will prevent the race condition where shutdown is processed by the server before all the other steps, which would prevent those steps from occurring Signed-off-by: Flavia Rainone <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cfdc473 - Browse repository at this point
Copy the full SHA cfdc473View commit details -
[UNDERTOW-2449] Revert changes that have been merged by mistake in CI…
… when investigating PushResourceRSTTestCase Signed-off-by: Flavia Rainone <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1d1371f - Browse repository at this point
Copy the full SHA 1d1371fView commit details -
[UNDERTOW-2449] Disable PushResourceRSTTestCase. We are still seeing …
…failures in CI. Signed-off-by: Flavia Rainone <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0ef8d7c - Browse repository at this point
Copy the full SHA 0ef8d7cView commit details -
[UNDERTOW-2446] HttpServletRequestImpl.getParts shouldn't throw excep…
…tion after already loading parts
Configuration menu - View commit details
-
Copy full SHA for b3ede9c - Browse repository at this point
Copy the full SHA b3ede9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c37d94c - Browse repository at this point
Copy the full SHA c37d94cView commit details -
[UNDERTOW-2422] Return the protocol field of the HttpServerExchange i…
…nto the status line. Add tests for this and the default behavior. Signed-off-by: Flavia Rainone <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0c0ffc4 - Browse repository at this point
Copy the full SHA 0c0ffc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9990fbc - Browse repository at this point
Copy the full SHA 9990fbcView commit details -
[UNDERTOW-2448] At ServletPrintWriter.write(CharBuffer) do not mark e…
…rror if buffer.remaining() == remaining after flush. We need to update remaining to do a proper check here. The aforementioned == check can return true after a successfull flush, because "remaining" value is set to be the size of the bytes remaining in the buffer before encoding. If, at that stage, the buffer is empty, "remaining" value is set to buffer.capacity(). When encoding many bytes, we will end up with a full buffer. As a result, we will try to flush, and it is often the case that the buffer will be entirely cleared after flushing. This results in buffer.remaining() being the overall buffer size, i.e., buffer.capacity(). As a result, buffer.remaining() == remaining check returns true, and write is aborted, causing the broken responses we are seeing. Signed-off-by: Flavia Rainone <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4fe95e7 - Browse repository at this point
Copy the full SHA 4fe95e7View commit details