Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNDERTOW-2412 / 2445 / 2449 / 2446 / 2436 / 2422 / 2444 / 2448] Backport fixes to 2.3.x #1687

Merged
merged 10 commits into from
Oct 16, 2024

Commits on Oct 11, 2024

  1. [UNDERTOW-2412] Read stored json with default UTF-8 encoding

    Signed-off-by: Flavia Rainone <[email protected]>
    schnapster authored and fl4via committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    17fd02a View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. [UNDERTOW-2445] Fix the CI by upgrading all instances of upload-artif…

    …act and download-artifact actions to v4
    
    Signed-off-by: Flavia Rainone <[email protected]>
    fl4via committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    69d8866 View commit details
    Browse the repository at this point in the history
  2. [UNDERTOW-2449] Fix PushResourceRSTTestCase by shutting down writes a…

    …nd adding a response listener only after push resource has been handled by the listener
    
    This will prevent the race condition where shutdown is processed by the server before all the other steps, which would prevent those steps from occurring
    
    Signed-off-by: Flavia Rainone <[email protected]>
    fl4via committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    cfdc473 View commit details
    Browse the repository at this point in the history
  3. [UNDERTOW-2449] Revert changes that have been merged by mistake in CI…

    … when investigating PushResourceRSTTestCase
    
    Signed-off-by: Flavia Rainone <[email protected]>
    fl4via committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    1d1371f View commit details
    Browse the repository at this point in the history
  4. [UNDERTOW-2449] Disable PushResourceRSTTestCase. We are still seeing …

    …failures in CI.
    
    Signed-off-by: Flavia Rainone <[email protected]>
    fl4via committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0ef8d7c View commit details
    Browse the repository at this point in the history
  5. [UNDERTOW-2446] HttpServletRequestImpl.getParts shouldn't throw excep…

    …tion after already loading parts
    aogburn authored and fl4via committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b3ede9c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c37d94c View commit details
    Browse the repository at this point in the history
  7. [UNDERTOW-2422] Return the protocol field of the HttpServerExchange i…

    …nto the status line.
    
    Add tests for this and the default behavior.
    
    Signed-off-by: Flavia Rainone <[email protected]>
    EarthJeff authored and fl4via committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0c0ffc4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9990fbc View commit details
    Browse the repository at this point in the history
  9. [UNDERTOW-2448] At ServletPrintWriter.write(CharBuffer) do not mark e…

    …rror if buffer.remaining() == remaining after flush. We need to update remaining to do a proper check here.
    
    The aforementioned == check can return true after a successfull flush, because "remaining" value is set to be the size of the bytes remaining in the buffer before encoding. If, at that stage, the buffer is empty, "remaining" value is set to buffer.capacity(). When encoding many bytes, we will end up with a full buffer. As a result, we will try to flush, and it is often the case that the buffer will be entirely cleared after flushing. This results in buffer.remaining() being the overall buffer size, i.e., buffer.capacity(). As a result, buffer.remaining() == remaining check returns true, and write is aborted, causing the broken responses we are seeing.
    
    Signed-off-by: Flavia Rainone <[email protected]>
    fl4via committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4fe95e7 View commit details
    Browse the repository at this point in the history