[UNDERTOW-2412 / 2445 / 2449 / 2446 / 2436 / 2422 / 2444 / 2448] Backport fixes to 2.3.x #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Flavia Rainone <[email protected]>
…act and download-artifact actions to v4 Signed-off-by: Flavia Rainone <[email protected]>
…nd adding a response listener only after push resource has been handled by the listener This will prevent the race condition where shutdown is processed by the server before all the other steps, which would prevent those steps from occurring Signed-off-by: Flavia Rainone <[email protected]>
… when investigating PushResourceRSTTestCase Signed-off-by: Flavia Rainone <[email protected]>
…failures in CI. Signed-off-by: Flavia Rainone <[email protected]>
…tion after already loading parts
…nto the status line. Add tests for this and the default behavior. Signed-off-by: Flavia Rainone <[email protected]>
…rror if buffer.remaining() == remaining after flush. We need to update remaining to do a proper check here. The aforementioned == check can return true after a successfull flush, because "remaining" value is set to be the size of the bytes remaining in the buffer before encoding. If, at that stage, the buffer is empty, "remaining" value is set to buffer.capacity(). When encoding many bytes, we will end up with a full buffer. As a result, we will try to flush, and it is often the case that the buffer will be entirely cleared after flushing. This results in buffer.remaining() being the overall buffer size, i.e., buffer.capacity(). As a result, buffer.remaining() == remaining check returns true, and write is aborted, causing the broken responses we are seeing. Signed-off-by: Flavia Rainone <[email protected]>
fl4via
added
waiting CI check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jiras:
https://issues.redhat.com/browse/UNDERTOW-2412 main PR: #1545
https://issues.redhat.com/browse/UNDERTOW-2445 main PR: #1665 #1688
https://issues.redhat.com/browse/UNDERTOW-2449 main PR: #1667 #1682
https://issues.redhat.com/browse/UNDERTOW-2446 main PR: #1666
https://issues.redhat.com/browse/UNDERTOW-2436 main PR: #1661
https://issues.redhat.com/browse/UNDERTOW-2422 main PR: #1644
https://issues.redhat.com/browse/UNDERTOW-2444 main PR: #1662
https://issues.redhat.com/browse/UNDERTOW-2448 main PR: #1683
2.2.x PR: #1689