Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Navigation shutdown behavior #627

Merged
merged 6 commits into from
Dec 30, 2023
Merged

Fix Navigation shutdown behavior #627

merged 6 commits into from
Dec 30, 2023

Conversation

qhdwight
Copy link
Collaborator

  • Fixes shutdown behavior (closes instead of hangs)
  • Changes message format

@qhdwight qhdwight marked this pull request as ready for review December 30, 2023 22:53
@qhdwight qhdwight changed the title Navigation changes Fix Navigation shutdown behavior Dec 30, 2023
@qhdwight qhdwight merged commit f7a8877 into master Dec 30, 2023
1 check passed
@qhdwight qhdwight deleted the nav-changes branch December 30, 2023 23:15
Emerson-Ramey
Emerson-Ramey reviewed Dec 31, 2023
View reviewed changes
Copy link
Contributor

@Emerson-Ramey Emerson-Ramey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed this and it looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emerson-Ramey Emerson-Ramey Emerson-Ramey left review comments

@ankithu ankithu Awaiting requested review from ankithu

Assignees
No one assigned
Labels
2024 navigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qhdwight @Emerson-Ramey