As I was fetching the research this exact bounty came to my mind after learning recently assignees don't get comment incentives, I'll be quicker next time ;)

I think it should just be

/incentivize keyrxng

This command should work in any order, like our other commands.

In my head I thought if they are the assignee of the task then they'll receive no rewards as standard, after the PR is merged and all rewards are allocated then the command is invoked and the bot hoovers up the assignee's comments, does the calc and generates the permit.

But in any order would imply that this command can be invoked from issue open not just issue close.

So would it make sense to follow this path:

• run command ``/incentivize keyrxng''
• if issue is closed, gather all assignee comments, do the sums and generate the permit
• if issue is open, just enable rewards for the assignee (is that for the whole issue or from command onwards?) and they can claim alongside the rest of rewards at PR merge either as one or as two separate permits?

To simplify the implementation, the bot should just look for the instance of this comment in the issue at the moment the issue is closed as completed.

If for some reason it was closed as completed, but the admin wanted to provide these rewards, they simply post the command, and then re-open and re-close as complete.

"any order" refers to the arguments. true or false for the state and the usernames (any amount of) should work

/incentivize isn't specific enough. You already would have received the assignee incentive in the above scenario.

To simplify the implementation, the bot should just look for the instance of this comment in the issue at the moment the issue is closed as completed.

I'm hearing that the command itself is more of a pseudo command and acts more like a placeholder than anything else?

We can create a Pre callBack for issueClosed events and check before each issue is closed for the placeholder, if it exists pass in the usernames that comment contains and calculate their incentives before closing the issue outright?

It can be safeguarded by checking whoever wrote the command has sufficient access/authority to do so

Obv still add it to the list of available commands via the /help command but the command itself doesn't actually execute any logic. It could be logged "x has started earning rewards on issue 123" when invoked but the actual logic would be executed as part of the issueClose pre handler.

it might be rude of me but can i do this issue?

@me505 if that was aimed at myself don't be silly nothing rude about it, I'm here for the discussion at the moment and would have taken the bounty if left unassigned in a week or so. So you carry on mate

cant we just add a helper function which see who has been incentived by /comment-incentives @Keyrxng @user2 @user3 true and returns a list of the users to and iterates to see who can be incentivized inincentivizeComments post callback

/start

Tips:

• Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
• Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
• Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

We can create a Pre callBack for issueClosed events and check before each issue is closed for the placeholder, if it exists pass in the usernames that comment contains and calculate their incentives before closing the issue outright?

It can be safeguarded by checking whoever wrote the command has sufficient access/authority to do so

Yes this all sounds good to me.

cant we just add a helper function which see who has been incentived by /comment-incentives @Keyrxng @user2 @user3 true and returns a list of the users to and iterates to see who can be incentivized inincentivizeComments post callback

I think the simplest implementation would be if we use the comments as the "database" and the bot looks for this comment before posting all of the payments.

should the bot incentivize everyone by default @pavlovcik?

• https://github.com/Keyrxng/UbiquityBotTesting/issues/43#issuecomment-1712886879

Weird that on my repo where I implemented the whitespace removal you can clearly see the formatting for my table has slightly improved vs the one above, the changes have been merged in so they should be reflected here.

Not the end of the world but deffo an annoyance for me personally but if you think it's worth a debug I will look into it @pavlovcik

I couldnt figure out how to remove the monospace background artifact. I wouldnt go out of your way to solve it because I dont think its an easy fix, and its so low priority.

should the bot incentivize everyone by default @pavlovcik?

No but i'm pretty sure that this bounty has nothing to do with controlling that. That was handled as part of a different spec I believe.

If for some reason it was closed as completed, but the admin wanted to provide these rewards, they simply post the command, and then re-open and re-close as complete.

I think that won't work because permit was possibly already generated for that user and we have rule: one permit per user per issue

If for some reason it was closed as completed, but the admin wanted to provide these rewards, they simply post the command, and then re-open and re-close as complete.

I think that won't work because permit was possibly already generated for that user and we have rule: one permit per user per issue

It seems that the issuer might be the only one who would get screwed in this case. But even if that is an issue, an admin can delete their permit comment, and then regenerate it as long as they didn't already claim the first one the nonce is still valid.

@me505 - Releasing the bounty back to dev pool because the allocated duration already ended!
Last activity time: Mon Sep 18 2023 16:52:43 GMT+0000 (Coordinated Universal Time)

/start

Tips:

• Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
• Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
• Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

Do you have any updates @me505? If you would like to release the bounty back to the DevPool, please comment /stop
Last activity time: Sat Sep 30 2023 09:42:15 GMT+0000 (Coordinated Universal Time)

Do you have any updates @me505? If you would like to release the bounty back to the DevPool, please comment /stop
Last activity time: Thu Oct 05 2023 16:24:49 GMT+0000 (Coordinated Universal Time)

Wait James mcgee

Do you have any updates @me505? If you would like to release the bounty back to the DevPool, please comment /stop
Last activity time: Tue Oct 10 2023 14:27:58 GMT+0000 (Coordinated Universal Time)

Do you have any updates @me505? If you would like to release the bounty back to the DevPool, please comment /stop
Last activity time: Tue Oct 24 2023 04:42:23 GMT+0000 (Coordinated Universal Time)

Hmm

Do you have any updates @me505? If you would like to release the bounty back to the DevPool, please comment /stop
Last activity time: Sat Oct 28 2023 06:00:11 GMT+0000 (Coordinated Universal Time)

Waiting for the refactor to be done

Do you have any updates @me505? If you would like to release the bounty back to the DevPool, please comment /stop
Last activity time: Wed Nov 01 2023 12:39:33 GMT+0000 (Coordinated Universal Time)

My guy wait the refactor ain't done yet

Do you have any updates @me505? If you would like to release the bounty back to the DevPool, please comment /stop
Last activity time: Mon Nov 06 2023 08:54:59 GMT+0000 (Coordinated Universal Time)

My guy wait the refactor ain't done yet

.

Do you have any updates @me505? If you would like to release the bounty back to the DevPool, please comment /stop
Last activity time: Sat Nov 11 2023 08:31:54 GMT+0000 (Coordinated Universal Time)

@pavlovcik can you please also update the follow up time?

pavlovcik can you please also update the follow up time?

@me505 dude why don't you just unassign yourself using the UI and when things are ready the team will @ you to reassign yourself

Do you have any updates @me505? If you would like to release the bounty back to the DevPool, please comment /stop
Last activity time: Wed Nov 15 2023 14:34:49 GMT+0000 (Coordinated Universal Time)

@me505 - Releasing the bounty back to dev pool because the allocated duration already ended!
Last activity time: Wed Nov 15 2023 14:34:49 GMT+0000 (Coordinated Universal Time)