Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

feat: add comment-incentive command #840

Open
wants to merge 17 commits into
base: development
Choose a base branch
from

Conversation

BeanieMen
Copy link
Contributor

@BeanieMen BeanieMen commented Sep 26, 2023

Resolves #780

Quality Assurance:

@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for ubiquibot-staging ready!

Name Link
🔨 Latest commit 44c5ccb
🔍 Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/652d2986ee395a0008d88c27
😎 Deploy Preview https://deploy-preview-840--ubiquibot-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@0x4007
Copy link
Member

0x4007 commented Sep 26, 2023

Needs proof that it works before review

@0x4007 0x4007 marked this pull request as draft September 26, 2023 06:03
@BeanieMen
Copy link
Contributor Author

@pavlovcik #735 (comment)

@BeanieMen
Copy link
Contributor Author

can we rename comment-incentives to incentivize because somehow it is not working with comment-incentive @whilefoo

@BeanieMen BeanieMen marked this pull request as ready for review September 29, 2023 06:58
@BeanieMen
Copy link
Contributor Author

are comment incentives not generated for issue creator?

Copy link
Collaborator

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/comment-incentive should work, maybe it's something to do with regex because - is a special character, try to figure it out

src/helpers/issue.ts Show resolved Hide resolved
src/handlers/comment/handlers/incentivize.ts Outdated Show resolved Hide resolved
@whilefoo
Copy link
Collaborator

whilefoo commented Oct 4, 2023

@me505

@BeanieMen
Copy link
Contributor Author

@pavlovcik can /incentivize work instead of /comment-incentive

@BeanieMen
Copy link
Contributor Author

@pavlovcik can /incentivize work instead of /comment-incentive

@pavlovcik

@BeanieMen
Copy link
Contributor Author

@whilefoo the command is now working and so is the function
BeanieMen#14

@BeanieMen
Copy link
Contributor Author

can you just help me set up comment incentives to test if this works or not

src/handlers/payout/post.ts Outdated Show resolved Hide resolved
src/handlers/comment/handlers/comment-incentive.ts Outdated Show resolved Hide resolved
@whilefoo
Copy link
Collaborator

can you just help me set up comment incentives to test if this works or not

what's the issue?

@BeanieMen
Copy link
Contributor Author

the problem is that incentive rewards might not be getting calculated

@BeanieMen
Copy link
Contributor Author

i tried explicitly setting the rewardValue.sum to new Decimal(1) but to no avail

@BeanieMen
Copy link
Contributor Author

@whilefoo is there anything I need to setup for comment incentives

@whilefoo
Copy link
Collaborator

@me505 I think it's because creator is excluded from conversation rewards

if (permit.userId !== creatorReward.userId) {

@BeanieMen
Copy link
Contributor Author

i literally have no idea why this isnt working

@BeanieMen
Copy link
Contributor Author

BeanieMen#28

@BeanieMen
Copy link
Contributor Author

BeanieMen commented Oct 20, 2023

i am running the development branch which isn't changed in any way

@whilefoo
Copy link
Collaborator

you should comment with an account that is not creator or assignee

@BeanieMen
Copy link
Contributor Author

BeanieMen#31
BeanieMen#30

@BeanieMen
Copy link
Contributor Author

@whilefoo its working

@BeanieMen
Copy link
Contributor Author

@whilefoo can you review this

@BeanieMen
Copy link
Contributor Author

@pavlovcik am I able to work on this now?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selectively enabling comment incentives per task
3 participants