-
Notifications
You must be signed in to change notification settings - Fork 61
feat: add comment-incentive command #840
base: development
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Needs proof that it works before review |
can we rename comment-incentives to incentivize because somehow it is not working with comment-incentive @whilefoo |
are comment incentives not generated for issue creator? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/comment-incentive
should work, maybe it's something to do with regex because -
is a special character, try to figure it out
@me505 |
@pavlovcik can |
|
@whilefoo the command is now working and so is the function |
can you just help me set up comment incentives to test if this works or not |
what's the issue? |
the problem is that incentive rewards might not be getting calculated |
Co-authored-by: whilefoo <[email protected]>
Co-authored-by: whilefoo <[email protected]>
i tried explicitly setting the rewardValue.sum to new Decimal(1) but to no avail |
@whilefoo is there anything I need to setup for comment incentives |
@me505 I think it's because creator is excluded from conversation rewards ubiquibot/src/handlers/payout/action.ts Line 365 in 3ad77e5
|
i literally have no idea why this isnt working |
i am running the development branch which isn't changed in any way |
you should comment with an account that is not creator or assignee |
@whilefoo its working |
@whilefoo can you review this |
@pavlovcik am I able to work on this now? |
Resolves #780
Quality Assurance: