Replace codecov with local lcov #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage after merging jb/lcov into master will be
Coverage Report for Changed Files
|
|
Coverage after merging jb/lcov into master will be
Coverage Report for Changed Files
|
|
Coverage after merging jb/lcov into master will be
Coverage Report for Changed Files
|
|
This is great! And this should be sufficient, especially when we figure out the Cython tests to get 100% coverage. Let's try this out for a while, while we mull over the importance of the badge. :) |
ajfriend
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential solution to #393
The reporting isn't as pretty, and you don't get the full report. But it gets the job done without sending anything outside of the Github Actions instance.
Setup to use local coverage reporting for pull requests, and codecov for push to master.
Seems like once pushed to master, codecov pulls the proper secrets from
uber/h3-py(e.g., see this run onmastervs this failed run on a fork for the PR )We could just use lcov for everything, but then we'd have to give up the badge on
readme.md.