Skip to content

Commit

Permalink
Use local lcov for PRs and codecov for push to master (#413)
Browse files Browse the repository at this point in the history
  • Loading branch information
jongbinjung authored Oct 5, 2024
1 parent 98bf22a commit 91ab2bf
Show file tree
Hide file tree
Showing 3 changed files with 46 additions and 2 deletions.
45 changes: 45 additions & 0 deletions .github/workflows/coverage-lint-pr.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
name: pr-coverage-lint

on:
pull_request:
branches: ['*']

jobs:
tests:
name: Coverage and Lint
runs-on: ubuntu-22.04

steps:
- uses: actions/[email protected]
with:
submodules: recursive

- uses: actions/[email protected]
with:
python-version: 3.11

- name: Install from source
run: |
pip install --upgrade pip setuptools wheel
pip install .[test]
- name: Lint
run: flake8 src/h3 tests

- name: Pylint
# As a test for visibility of API bindings, we want to ensure that pylint has no
# `import-error` warnings for h3 imports.
run: pylint --disable=all --enable=import-error tests/

- name: Coverage
run: |
pip install cython
cythonize tests/test_cython/cython_example.pyx
pytest --cov-report=lcov
- name: Report coverage
uses: romeovs/[email protected]
with:
filter-changed-files: true
github-token: ${{ secrets.GITHUB_TOKEN }}
lcov-file: ./coverage.lcov
2 changes: 0 additions & 2 deletions .github/workflows/coverage-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ name: coverage-lint
on:
push:
branches: [master]
pull_request:
branches: ['*']

jobs:
tests:
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ pip-log.txt
# Unit test / coverage reports
.coverage
coverage.xml
coverage.lcov
.tox
nosetests.xml
.noseids
Expand Down

0 comments on commit 91ab2bf

Please sign in to comment.