Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified to program and application (#4) #5

Merged
merged 25 commits into from
Mar 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
744e0b7
modified to program and application (#4)
ubc-tuehoang Feb 23, 2024
6492ac6
updated from Pan recommendation
tuehoang Mar 5, 2024
a7c0e8f
updated and modified apps to applications
tuehoang Mar 26, 2024
5faacb9
Merge branch 'master' into hotcrp_program_app
xcompass Mar 26, 2024
35a03dc
updated test for conference to program
tuehoang Mar 26, 2024
825d5c2
updated test for conference to program
tuehoang Mar 26, 2024
37c1645
test removal of test01,05,08
tuehoang Mar 26, 2024
ca7f70b
removed all tests to reduce noise and check each one
tuehoang Mar 26, 2024
2ceae68
add test01 back for testing
tuehoang Mar 26, 2024
60d73f0
updated string in emails txt
tuehoang Mar 26, 2024
08d7a5e
updated string in emails txt
tuehoang Mar 26, 2024
3dd8b90
added test02 back to the check.sh list
tuehoang Mar 26, 2024
d7db0c8
added all tests back to check.sh
tuehoang Mar 26, 2024
bd9716e
added test03 back to check.sh
tuehoang Mar 26, 2024
9225167
added test04 back to check.sh
tuehoang Mar 26, 2024
6fbb03b
added test05 back to check.sh
tuehoang Mar 27, 2024
ff0220e
added test06 back to check.sh
tuehoang Mar 27, 2024
d3ce377
fixed test06 issues
tuehoang Mar 27, 2024
018d138
fixed test06 issues
tuehoang Mar 27, 2024
477c09f
fixed test06 issues
tuehoang Mar 27, 2024
0f03e6b
fixed test06 issues
tuehoang Mar 27, 2024
6765fb1
added test07 to the check.sh
tuehoang Mar 27, 2024
e260505
added test08 to the check.sh
tuehoang Mar 27, 2024
534f9c8
added test08 for validation to the check.sh
tuehoang Mar 27, 2024
4ab2b67
added test08 to remove validation to the check.sh
tuehoang Mar 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions etc/autoassigners.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,15 @@
"name": "review_ensure",
"function": "+Review_Autoassigner",
"parameters": [
"count {n} Number of reviews to ensure per paper",
"count {n} Number of reviews to ensure per application",
"$__review_parameters"
]
},
{
"name": "review_adjust",
"function": "+Review_Autoassigner",
"parameters": [
"count {n} Number of reviews to ensure per paper",
"count {n} Number of reviews to ensure per application",
"$__review_parameters"
]
},
Expand Down
12 changes: 6 additions & 6 deletions etc/helptopics.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[
{
"name": "chair", "title": "Chair’s guide", "order": 0,
"description": "<0>How to run a conference using HotCRP."
"description": "<0>How to run a program using HotCRP."
},
{
"name": "chair/presubmission", "order": 0,
Expand Down Expand Up @@ -189,7 +189,7 @@
},
{
"name": "search", "title": "Search",
"description": "<0>About paper searching.",
"description": "<0>About application searching.",
"print_function": "Search_HelpTopic::print",
"order": 1000
},
Expand All @@ -202,7 +202,7 @@
{ "name": "syntax", "alias": "keywords" },
{
"name": "tags", "title": "Tags",
"description": "<0>How to use tags to define paper sets and discussion orders.",
"description": "<0>How to use tags to define application sets and discussion orders.",
"print_function": "*Tags_HelpTopic::print_intro",
"order": 3000
},
Expand Down Expand Up @@ -261,7 +261,7 @@
},
{
"name": "scoresort", "title": "Sorting scores",
"description": "<0>How scores are sorted in paper lists.",
"description": "<0>How scores are sorted in application lists.",
"print_function": "ScoreSort_HelpTopic::print",
"order": 5000
},
Expand All @@ -280,14 +280,14 @@
{ "name": "revrate", "alias": "reviewratings" },
{
"name": "voting", "title": "Voting",
"description": "<0>PC members can vote for papers using tags.",
"description": "<0>PC members can vote for applications using tags.",
"print_function": "VoteTags_HelpTopic::print",
"order": 8000
},
{ "name": "votetags", "alias": "voting" },
{
"name": "ranking", "title": "Ranking",
"description": "<0>PC members can rank papers using tags.",
"description": "<0>PC members can rank applications using tags.",
"print_function": "Ranking_HelpTopic::print",
"order": 9000
},
Expand Down
20 changes: 10 additions & 10 deletions etc/listactions.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,23 @@
},
{
"name": "get/json", "get": true,
"title": "Paper information/JSON",
"title": "Application information/JSON",
"order": 10090,
"allow_if": "manager",
"function": "+GetJson_ListAction",
"has_attachments": false
},
{
"name": "get/jsonattach", "get": true,
"title": "Paper information/JSON with attachments",
"title": "Application information/JSON with attachments",
"order": 10091,
"allow_if": "manager",
"function": "+GetJson_ListAction",
"has_attachments": true
},
{
"name": "get/jsonrqc", "get": true,
"title": "Paper information/JSON for reviewqualitycollector.org",
"title": "Application information/JSON for reviewqualitycollector.org",
"order": 10092,
"allow_if": "manager",
"function": "+GetJsonRQC_ListAction"
Expand Down Expand Up @@ -72,7 +72,7 @@
},
{
"name": "get/revt", "get": true,
"title": "Reviews/Reviews with paper info",
"title": "Reviews/Reviews with application info",
"order": 30050,
"allow_if": "view_review",
"function": "+GetReviews_ListAction",
Expand Down Expand Up @@ -198,40 +198,40 @@
},
{
"name": "get/abstract", "get": true,
"title": "Paper information/Text with abstracts", "display_if": "listhas:abstract",
"title": "Application information/Text with abstracts", "display_if": "listhas:abstract",
"order": 10000,
"function": "+GetAbstracts_ListAction"
},
{
"name": "get/abstract", "get": true,
"title": "Paper information/Text", "display_if": "!listhas:abstract",
"title": "Application information/Text", "display_if": "!listhas:abstract",
"order": 10000,
"function": "+GetAbstracts_ListAction"
},
{
"name": "get/authors", "get": true,
"title": "Paper information/Authors",
"title": "Application information/Authors",
"order": 10001, "display_if": "listhas:authors",
"require": "src/listactions/la_get_sub.php",
"function": "+GetAuthors_ListAction"
},
{
"name": "get/topics", "get": true,
"title": "Paper information/Topics", "display_if": "conf.has_topics",
"title": "Application information/Topics", "display_if": "conf.has_topics",
"order": 10050,
"require": "src/listactions/la_get_sub.php",
"function": "+GetTopics_ListAction"
},
{
"name": "get/pcconf", "get": true,
"title": "Paper information/PC conflicts",
"title": "Application information/PC conflicts",
"order": 10060,
"require": "src/listactions/la_get_sub.php",
"function": "+GetPcconflicts_ListAction"
},
{
"name": "get/csv", "get": true,
"title": "Paper information/CSV",
"title": "Application information/CSV",
"order": 10089,
"require": "src/listactions/la_get_sub.php",
"function": "+GetCSV_ListAction"
Expand Down
6 changes: 3 additions & 3 deletions etc/mailtemplates.json
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@
"subject": "[%CONFSHORTNAME%] Withdrawn submission #%NUMBER% %TITLEHINT%",
"body": [
"Greetings,\n\n",
"%CONFSHORTNAME% submission #%NUMBER%, which you reviewed or were assigned to review, has been withdrawn from consideration for the conference.\n\n",
"%CONFSHORTNAME% submission #%NUMBER%, which you reviewed or were assigned to review, has been withdrawn from consideration for the program.\n\n",
"%IF(ADMINUPDATE)%An administrator withdrew the submission.%ELSE%Authors can withdraw submissions during the review process.%ENDIF%%IF(REASON)% They provided this reason: %REASON%%ENDIF%\n\n",
"* Title: %TITLE%\n",
"* Author(s): %OPT(AUTHORS)%\n",
Expand Down Expand Up @@ -698,7 +698,7 @@
"subject": "[%CONFSHORTNAME%] Accepted submission #%NUMBER% %TITLEHINT%",
"body": [
"Dear author(s),\n\n",
"The %CONFNAME% program committee is delighted to inform you that your submission #%NUMBER% has been accepted to appear in the conference.\n\n",
"The %CONFNAME% program committee is delighted to inform you that your submission #%NUMBER% has been accepted to appear in the program.\n\n",
"* Title: %TITLE%\n",
"* Author(s): %OPT(AUTHORS)%\n",
"* Site: %URL(paper, p=%NUMBER%, %AUTHORVIEWCAPABILITY%)%\n\n",
Expand All @@ -719,7 +719,7 @@
"subject": "[%CONFSHORTNAME%] Rejected submission #%NUMBER% %TITLEHINT%",
"body": [
"Dear author(s),\n\n",
"The %CONFNAME% program committee is sorry to inform you that your submission #%NUMBER% was rejected, and will not appear in the conference.\n\n",
"The %CONFNAME% program committee is sorry to inform you that your submission #%NUMBER% was rejected, and will not appear in the program.\n\n",
"* Title: %TITLE%\n",
"* Author(s): %OPT(AUTHORS)%\n",
"* Site: %URL(paper, p=%NUMBER%, %AUTHORVIEWCAPABILITY%)%\n\n",
Expand Down
18 changes: 9 additions & 9 deletions etc/msgs.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

["<0>A {submission} may have at most {max} authors", "<0>A {submission} may have at most one author", ["{max}=1"]],

["{} papers accepted out of {} submitted.", "{} paper accepted out of {} submitted.", ["{0}=1"]],
["{} applications accepted out of {} submitted.", "{} application accepted out of {} submitted.", ["{0}=1"]],

["<5>{sclass} registration deadline", "<5>Registration deadline", ["!{sclass}"]],
["<5>You can register new {sclass} {submissions} until this deadline.", "<5>You can register new {submissions} until this deadline.", ["!{sclass}"]],
Expand Down Expand Up @@ -207,19 +207,19 @@
]
},

["resp_instrux", "The authors’ response should address reviewer concerns and correct misunderstandings. Make it short and to the point; the conference deadline has passed."],
["resp_instrux", "The authors’ response should address reviewer concerns and correct misunderstandings. Make it short and to the point; the conference deadline has passed. Try to stay within {wordlimit} words.", ["{wordlimit}>0"]],
["resp_instrux", "The authors’ response should address reviewer concerns and correct misunderstandings. Make it short and to the point; the program deadline has passed."],
["resp_instrux", "The authors’ response should address reviewer concerns and correct misunderstandings. Make it short and to the point; the program deadline has passed. Try to stay within {wordlimit} words.", ["{wordlimit}>0"]],

{"in": "conflictdef", "out": "This includes past advisors and students, people with the same affiliation, and any recent (~2 years) coauthors and collaborators.", "template": true},

{"in": "finalsubmit", "out": "Congratulations! The paper has been accepted. Update the paper’s final version here. {deadline} You may also edit paper contacts, allowing others to view reviews and make changes."},
{"in": "finalsubmit", "out": "Congratulations! The application has been accepted. Update the application’s final version here. {deadline} You may also edit application contacts, allowing others to view reviews and make changes."},

{"in": "revprefdescription", "out": "<5><p>A review preference is a small integer that indicates how much you want to review a submission. Positive numbers mean you want to review, negative numbers mean you don’t, and −100 means you think you have a conflict. −20 to 20 is a typical range for real preferences; multiple submissions can have the same preference. The automatic assignment algorithm attempts to assign reviews in descending preference order. Different users’ preference values are not compared and need not use the same scale.</p>\n\n<p>Select a column heading to sort by that column. Enter preferences in the text boxes or on the paper pages. You may also upload preferences from a text file; see the “Download” and “Upload” links below the paper list.</p>"},
{"in": "revprefdescription", "out": "<5><p>A review preference is a small integer that indicates how much you want to review a submission. Positive numbers mean you want to review, negative numbers mean you don’t, and −100 means you think you have a conflict. −20 to 20 is a typical range for real preferences; multiple submissions can have the same preference. The automatic assignment algorithm attempts to assign reviews in descending preference order, using topic scores to break ties. Different users’ preference values are not compared and need not use the same scale.</p>\n\n<p>The list shows all submissions and their topics (<span class=\"topic4\">high interest topics</span>, <span class=\"topic-2\">low interest topics</span>). “Topic score” summarizes your interest in the submission’s topics. Select a column heading to sort by that column. Enter preferences in the text boxes or on the paper pages. You may also upload preferences from a text file; see the “Download” and “Upload” links below the paper list.</p>", "require": ["{topics}"]},
{"in": "revprefdescription", "out": "<5><p>A review preference is a small integer that indicates how much you want to review a submission. Positive numbers mean you want to review, negative numbers mean you don’t, and −100 means you think you have a conflict. −20 to 20 is a typical range for real preferences; multiple submissions can have the same preference. The automatic assignment algorithm attempts to assign reviews in descending preference order. Different users’ preference values are not compared and need not use the same scale.</p>\n\n<p>Select a column heading to sort by that column. Enter preferences in the text boxes or on the application pages. You may also upload preferences from a text file; see the “Download” and “Upload” links below the application list.</p>"},
{"in": "revprefdescription", "out": "<5><p>A review preference is a small integer that indicates how much you want to review a submission. Positive numbers mean you want to review, negative numbers mean you don’t, and −100 means you think you have a conflict. −20 to 20 is a typical range for real preferences; multiple submissions can have the same preference. The automatic assignment algorithm attempts to assign reviews in descending preference order, using topic scores to break ties. Different users’ preference values are not compared and need not use the same scale.</p>\n\n<p>The list shows all submissions and their topics (<span class=\"topic4\">high interest topics</span>, <span class=\"topic-2\">low interest topics</span>). “Topic score” summarizes your interest in the submission’s topics. Select a column heading to sort by that column. Enter preferences in the text boxes or on the application pages. You may also upload preferences from a text file; see the “Download” and “Upload” links below the application list.</p>", "require": ["{topics}"]},

["external_review_request_description", "External reviewers may view their assigned papers. Before requesting an external review, you should generally check whether they are interested."],
["external_review_request_description", "External reviewers may view their assigned papers, including other reviews and the eventual decision. Before requesting an external review, you should generally check whether they are interested.", ["setting.viewrev_ext>=0"]],
["external_review_request_description", "External reviewers may view their assigned papers, including other reviews and reviewer identities and the eventual decision. Before requesting an external review, you should generally check whether they are interested.", ["setting.viewrev_ext>=0", "setting.viewrevid_ext>=0"]],
["external_review_request_description", "External reviewers may view their assigned applications. Before requesting an external review, you should generally check whether they are interested."],
["external_review_request_description", "External reviewers may view their assigned applications, including other reviews and the eventual decision. Before requesting an external review, you should generally check whether they are interested.", ["setting.viewrev_ext>=0"]],
["external_review_request_description", "External reviewers may view their assigned applications, including other reviews and reviewer identities and the eventual decision. Before requesting an external review, you should generally check whether they are interested.", ["setting.viewrev_ext>=0", "setting.viewrevid_ext>=0"]],

["({} more permissions have default values)", "({} more permission has default value)", ["{0}=1"]],

Expand Down
32 changes: 16 additions & 16 deletions etc/reviewfieldlibrary.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@
"type": "radio",
"values": [
"Reject",
"Weak paper, though I will not fight strongly against it",
"OK paper, but I will not champion it",
"Good paper, I will champion it"
"Weak application, though I will not fight strongly against it",
"OK application, but I will not champion it",
"Good application, I will champion it"
],
"start": "A",
"flip": true,
Expand All @@ -94,11 +94,11 @@
"name": "Overall merit",
"type": "radio",
"values": [
"Bottom 50% of submitted papers",
"Top 50% but not top 25% of submitted papers",
"Top 25% but not top 10% of submitted papers",
"Top 10% but not top 5% of submitted papers",
"Top 5% of submitted papers!"
"Bottom 50% of submitted applications",
"Top 50% but not top 25% of submitted applications",
"Top 25% but not top 10% of submitted applications",
"Top 10% but not top 5% of submitted applications",
"Top 5% of submitted applications!"
],
"required": true,
"visibility": "au"
Expand Down Expand Up @@ -147,17 +147,17 @@
"scheme": "orbu"
},
{
"legend": "Paper summary",
"name": "Paper summary",
"legend": "Application summary",
"name": "Application summary",
"type": "text",
"description": "Please summarize the paper’s main results in your own words. This will frame the review and show that you have understood the paper’s intent.",
"description": "Please summarize the application’s main results in your own words. This will frame the review and show that you have understood the application’s intent.",
"visibility": "au"
},
{
"legend": "Paper summary (shorter description)",
"name": "Paper summary",
"legend": "Application summary (shorter description)",
"name": "Application summary",
"type": "text",
"description": "Please summarize the paper briefly in your own words.",
"description": "Please summarize the application briefly in your own words.",
"visibility": "au"
},
{
Expand Down Expand Up @@ -225,14 +225,14 @@
"legend": "Strengths",
"name": "Strengths",
"type": "text",
"description": "What are the paper’s important strengths? Just a couple sentences, please.",
"description": "What are the application’s important strengths? Just a couple sentences, please.",
"visibility": "au"
},
{
"legend": "Weaknesses",
"name": "Weaknesses",
"type": "text",
"description": "What are the paper’s important weaknesses? Just a couple sentences, please.",
"description": "What are the application’s important weaknesses? Just a couple sentences, please.",
"visibility": "au"
}
]
4 changes: 2 additions & 2 deletions etc/settinggroups.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
[
{
"name": "basics", "order": 0, "title": "Basics",
"description": "<0>Conference name, site contact, and email."
"description": "<0>Program name, site contact, and email."
},
{ "name": "info", "alias": "basics" },
{
"name": "basics/names", "order": 10,
"print_function": "Basics_SettingParser::print_names",
"title": "Conference information",
"title": "Program information",
"settings": [
"conference_abbreviation",
"conference_name",
Expand Down
12 changes: 6 additions & 6 deletions etc/settinginfo.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
[
{
"name": "conference_abbreviation", "storage": "opt.shortName",
"title": "Conference abbreviation",
"title": "Program abbreviation",
"type": "simplestring", "size": 20, "autogrow": true,
"parser_class": "Basics_SettingParser"
},
{
"name": "conference_name", "storage": "opt.longName",
"title": "Conference name", "placeholder": "(same as abbreviation)",
"title": "Program name", "placeholder": "(same as abbreviation)",
"type": "simplestring", "size": 70,
"parser_class": "Basics_SettingParser"
},
Expand Down Expand Up @@ -164,7 +164,7 @@
},
{
"name": "conference_url", "storage": "opt.conferenceSite",
"title": "Conference URL",
"title": "Program URL",
"type": "url", "required": false, "size": 70, "placeholder": "N/A"
},
{
Expand Down Expand Up @@ -510,7 +510,7 @@
},
{
"name": "review_self_assign", "storage": "pcrev_any",
"title": "PC can review any paper",
"title": "PC can review any application",
"type": "checkbox", "initial_value": 1
},
{
Expand Down Expand Up @@ -870,7 +870,7 @@
},
{
"name_pattern": "format/$/papersize",
"title": "PDF format checker paper size",
"title": "PDF format checker application size",
"type": "string", "size": 18, "placeholder": "any"
},
{
Expand Down Expand Up @@ -989,7 +989,7 @@
},
{
"name": "tag_visibility_conflict", "storage": "tag_seeall",
"title": "PC can see tags for conflicted papers",
"title": "PC can see tags for conflicted applications",
"type": "checkbox"
},
{
Expand Down
Loading
Loading