modified to program and application (#4) #5

ubc-tuehoang · 2024-03-04T21:12:23Z

update conference to program
updated paper to application
modified paper to application for json files
updated message
updated help log for paper
updated more help content fixes

* update conference to program * updated paper to application * modified paper to application for json files * updated message * updated help log for paper * updated more help content fixes --------- Co-authored-by: ubc-tuehoang <[email protected]>

xcompass

I also remember you said you are going to make variables for changing those texts. Did you give it up?

xcompass · 2024-03-04T21:39:18Z

.env.default

@@ -10,7 +10,6 @@ HOTCRP_CONTACT_NAME=Chairs
 HOTCRP_PAPER_SITE=


-


Could you remove this change? I would like minimal changes for the PR. Will be easier for merging in the future.

xcompass · 2024-03-04T21:43:53Z

src/help/h_chairsguide.php

-  members’ access rights for individual papers. Example situations calling for
-  tracks include external review committees, PC-paper review committees, and
-  multi-track conferences.</li>\n";
+  "</strong> Tracks give chairs fine-grained control over PC members’ access rights for individual papers. Example situations calling for tracks include external review committees, PC-paper review committees, and multi-track programs.</li>\n";


Could you not change the line breaks but just the text? again easier for future merge.

xcompass · 2024-03-04T21:43:58Z

src/help/h_chairsguide.php

-It is easiest to simply accept such conflicts as a fact of life. Chairs
-who can’t handle conflicts fairly shouldn’t be chairs. However, HotCRP
-does offer other mechanisms for conflicted reviews.</p>
+        echo "<p>Chairs and system administrators can access any information stored in the program system, including reviewer identities for conflicted papers. It is easiest to simply accept such conflicts as a fact of life. Chairs who can’t handle conflicts fairly shouldn’t be chairs. However, HotCRP does offer other mechanisms for conflicted reviews.</p>


Could you not change the line breaks but just the text? again easier for future merge.

xcompass · 2024-03-04T21:44:05Z

src/help/h_chairsguide.php

-papers, and can, for example, use the autoassignment tool, but they cannot change
-conference settings. When a paper
-has an administrator, chair conflicts cannot be overridden.</p>
+“Override conflicts” to access the assignment page.) Paper administrators have full privilege to assign and view reviews for their papers, and can, for example, use the autoassignment tool, but they cannot change program settings. When a paper has an administrator, chair conflicts cannot be overridden.</p>


Could you not change the line breaks but just the text? again easier for future merge.

xcompass · 2024-03-04T21:44:13Z

src/help/h_chairsguide.php

-            echo "<li><p><strong>Shepherding (optional).</strong> If your conference uses
-  shepherding for accepted papers, you can assign shepherds either ",
-  $hth->hotlink("paper by paper", "paper"), " or ", $hth->hotlink("automatically", "autoassign", "t=accepted"), ".</p></li>\n";
+            echo "<li><p><strong>Shepherding (optional).</strong> If your program uses shepherding for accepted applications, you can assign shepherds either ",


Could you not change the line breaks but just the text? again easier for future merge.

xcompass · 2024-03-04T21:44:57Z

src/help/h_tags.php

-It’s easy to change tags and to list all papers with a given tag,
-and <em>ordered</em> tags preserve a particular paper order.
-Tags also affect color highlighting in paper lists.</p>
+        echo "<p>PC members and administrators can attach tag names to applicaitons. It’s easy to change tags and to list all applications with a given tag, and <em>ordered</em> tags preserve a particular application order. Tags also affect color highlighting in application lists.</p>


Could you not change the line breaks but just the text? again easier for future merge.

xcompass · 2024-03-04T21:45:01Z

src/help/h_tags.php


 <div class=\"mb-p\">", $hth->search_form("#discuss"), "</div>

-<p>You can also search with “", $hth->search_link("show:tags"), "” to see each
-paper’s tags, or “", $hth->search_link("show:#tagname"), "” to see a particular tag
+<p>You can also search with “", $hth->search_link("show:tags"), "” to see each application’s tags, or “", $hth->search_link("show:#tagname"), "” to see a particular tag


Could you not change the line breaks but just the text? again easier for future merge.

xcompass · 2024-03-04T21:46:35Z

src/pages/p_home.php

@@ -179,10 +179,15 @@ function print_message() {
    }

    function print_welcome() {
+        echo '<div id="motivationalQuotes">


what about this change?

It was for fun - I will remove it. 😀

xcompass · 2024-03-04T21:46:48Z

src/pages/p_mergeaccounts.php

-papers using different email addresses. This form will allow you to transfer information
-between accounts, including authorship, reviews, and PC status. (Note that the
-transfer will only affect information currently stored in this conference.)</p></div>';
+            'You may have multiple accounts registered; perhaps you were asked to review applications using different email addresses. This form will allow you to transfer information between accounts, including authorship, reviews, and PC status. (Note that the transfer will only affect information currently stored in this program.)</p></div>';


Could you not change the line breaks but just the text? again easier for future merge.

xcompass · 2024-03-04T21:47:03Z

src/userstatus.php

@@ -1643,8 +1643,7 @@ static function print_topics(UserStatus $us) {
            return;
        }
        $us->cs()->add_section_class("w-text fx1")->print_start_section("Topic interests");
-        echo '<p>Please indicate your interest in reviewing papers on these conference
-topics. We use this information to help match papers to reviewers.</p>',
+        echo '<p>Please indicate your interest in reviewing applications on these program topics. We use this information to help match papers to reviewers.</p>',


Could you not change the line breaks but just the text? again easier for future merge.

Just a reminder to change this.

xcompass · 2024-03-22T17:50:35Z

src/userstatus.php

@@ -1643,8 +1643,7 @@ static function print_topics(UserStatus $us) {
            return;
        }
        $us->cs()->add_section_class("w-text fx1")->print_start_section("Topic interests");
-        echo '<p>Please indicate your interest in reviewing papers on these conference
-topics. We use this information to help match papers to reviewers.</p>',
+        echo '<p>Please indicate your interest in reviewing applications on these program topics. We use this information to help match papers to reviewers.</p>',


Just a reminder to change this.

xcompass · 2024-03-22T17:52:08Z

src/help/h_chairsguide.php

@@ -89,9 +89,9 @@ static function print_assignments(HelpRenderer $hth, $gj) {
            echo "</ol>\n\n";

        } else if ($gj->itemid === 1) {
-            echo "<li><p>Consider checking ", $hth->search_link("the papers", ["q" => "", "t" => "all"]),
+            echo "<li><p>Consider checking ", $hth->search_link("the apps", ["q" => "", "t" => "all"]),


Could you change all app and apps to application and applications? The wording apps may confuse applicants.

xcompass · 2024-03-22T17:52:33Z

Thanks for the update. Almost there.

xcompass · 2024-03-26T21:06:07Z

Looks like some of the text in the tests are not updated causing the tests failing. Could you check? @tuehoang

ubc-tuehoang requested a review from xcompass March 4, 2024 21:13

xcompass requested changes Mar 4, 2024

View reviewed changes

updated from Pan recommendation

6492ac6

xcompass requested changes Mar 22, 2024

View reviewed changes

tuehoang and others added 2 commits March 26, 2024 13:47

updated and modified apps to applications

a7c0e8f

Merge branch 'master' into hotcrp_program_app

5faacb9

tuehoang added 21 commits March 26, 2024 14:39

updated test for conference to program

35a03dc

updated test for conference to program

825d5c2

test removal of test01,05,08

37c1645

removed all tests to reduce noise and check each one

ca7f70b

add test01 back for testing

2ceae68

updated string in emails txt

60d73f0

updated string in emails txt

08d7a5e

added test02 back to the check.sh list

3dd8b90

added all tests back to check.sh

d7db0c8

added test03 back to check.sh

bd9716e

added test04 back to check.sh

9225167

added test05 back to check.sh

6fbb03b

added test06 back to check.sh

ff0220e

fixed test06 issues

d3ce377

fixed test06 issues

018d138

fixed test06 issues

477c09f

fixed test06 issues

0f03e6b

added test07 to the check.sh

6765fb1

added test08 to the check.sh

e260505

added test08 for validation to the check.sh

534f9c8

added test08 to remove validation to the check.sh

4ab2b67

xcompass merged commit 925321f into master Mar 27, 2024
10 checks passed

xcompass deleted the hotcrp_program_app branch March 27, 2024 21:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

modified to program and application (#4) #5

modified to program and application (#4) #5

ubc-tuehoang commented Mar 4, 2024

xcompass left a comment

xcompass Mar 4, 2024

xcompass Mar 4, 2024

xcompass Mar 4, 2024

xcompass Mar 4, 2024

xcompass Mar 4, 2024

xcompass Mar 4, 2024

xcompass Mar 4, 2024

xcompass Mar 4, 2024

ubc-tuehoang Mar 5, 2024

xcompass Mar 4, 2024

xcompass Mar 4, 2024

xcompass Mar 22, 2024

xcompass Mar 22, 2024

xcompass Mar 22, 2024

xcompass commented Mar 22, 2024

xcompass commented Mar 26, 2024

		@@ -10,7 +10,6 @@ HOTCRP_CONTACT_NAME=Chairs
		HOTCRP_PAPER_SITE=

modified to program and application (#4) #5

modified to program and application (#4) #5

Conversation

ubc-tuehoang commented Mar 4, 2024

xcompass left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xcompass commented Mar 22, 2024

xcompass commented Mar 26, 2024