Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Demographics and Health section and Data page #684

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

cstephen
Copy link
Contributor

@cstephen cstephen commented Dec 6, 2024

This is a draft PR that makes 15+ small demographics-and-health related text changes. I'm keeping this in draft mode until the demographics.shp file has been updated with the margin-of-error → confidence interval changes, the API has been updated accordingly in its demographics_updates branch, and NCR has been updated to handle the new field names, etc., as needed in this branch.

@cstephen cstephen marked this pull request as draft December 6, 2024 01:45
@Joshdpaul
Copy link

@cstephen The ACS data that is currently in the tool is actually from years 2018-2022 (we must have missed updating this citation) and so I think the citation on the data page needs to read "2018-2022" even if we don't update the ACS data

@cstephen cstephen marked this pull request as ready for review December 7, 2024 00:57
@cstephen
Copy link
Contributor Author

cstephen commented Dec 7, 2024

Good catch, @Joshdpaul. I've updated the date range to 2018-2022 for now, and we can update it again later if we do end up incorporating the 2019-2023 data.

I think this PR is ready to review now, using the approach of calculating the confidence interface from the margin of error in the webapp code instead of updating the shapefile/API.

To test, run:

cd northern-climate-reports
export SNAP_API_URL=https://development.earthmaps.io
nvm use lts/fermium
npm run dev

Then view the webapp running at http://localhost:3000/

Please confirm that all of the changes listed in the Google Doc under the "2024.12.04 Revisions" section have been completed (except for changes to the CSV file). Thanks!

@cstephen cstephen requested a review from Joshdpaul December 7, 2024 00:59
Copy link

@Joshdpaul Joshdpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the changes here address all issues listed in the "2024.12.04 Revisions", except for number 8 (hover/popup box) and number 7 (CSV revisions, which are addressed in the data API repo here)

@Joshdpaul Joshdpaul merged commit 49ec608 into main Dec 12, 2024
1 check failed
@Joshdpaul Joshdpaul deleted the demographics_updates branch December 12, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants