Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demographics and health endpoint and CSV updates #496

Merged
merged 8 commits into from
Dec 9, 2024

Conversation

cstephen
Copy link
Contributor

@cstephen cstephen commented Dec 6, 2024

This is a draft PR to implement the latest round of demographics & health changes. So far only the CSV filename & metadata have been updated, but we'll also need to make some updates to reflect the switch for margin-of-error (MOE) to high/low confidence intervals for several variables, as described in the Google Doc, once demographics.shp has been updated and uploaded to gs.earthmaps.io.

@cstephen cstephen marked this pull request as draft December 6, 2024 01:39
@Joshdpaul
Copy link
Contributor

I revised the field descriptions for the CSV output, and also added a new field with info about the source. Descriptive text here was copied verbatim from Micah's suggestions in this spreadsheet.

Tested Anchorage in the regular API output (http://localhost:5000/demographics/AK15 , not affected) and the CSV output (http://localhost:5000/demographics/AK15?format=csv , now contains the updated descriptions and new source column).

@Joshdpaul
Copy link
Contributor

@cstephen As discussed in the Slack, we implemented the conversion of margin-of-error (MOE) to high/low confidence intervals on the web app side via this PR instead of on the API side. So this PR just concerns the demographics CSV content.

We can merge these CSV changes now, and potentially revise the demographics.shp & upload to gs.earthmaps.io in the future.

@cstephen
Copy link
Contributor Author

cstephen commented Dec 9, 2024

@Joshdpaul, I did a side-by-side comparison of the spreadsheet they provided vs. the API CSV. The "Data source" column values look good, but I noticed some ambiguity in the spreadsheet they provided. There are effectively two different "new description" columns. Looks like you updated the descriptions based on the first "new description" column, but there's another description column highlighted in green (second to the last column).

Based on the yellow comment at the top of their spreadsheet, the second-to-last description column highlighted in green is their preferred version. This version shortens the description column by removing data source information. Looks like we'll want to use this one. I 100% understand the confusion though!

@cstephen cstephen merged commit eccd8c4 into main Dec 9, 2024
@cstephen cstephen deleted the demographics_updates branch December 9, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants