Added version bound check and added slash #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-mie6
commented
Sep 15, 2023
github/src/main/scala/org/typelevel/sbt/TypelevelGitHubPlugin.scala
Outdated
Show resolved
Hide resolved
|
I've checked this against |
armanbilge
reviewed
Sep 15, 2023
Comment on lines
+97
to
+98
| s"${info.browseUrl}/blob/${vh}/€{FILE_PATH}.scala" | ||
| else s"${info.browseUrl}/blob/${vh}€{FILE_PATH}.scala" |
There was a problem hiding this comment.
Dumb question: what if we just always put the slash? Does it work with 2.12, old 2.13s?
There was a problem hiding this comment.
I wondered about this, then I didn't want to play with 🔥
There was a problem hiding this comment.
Conclusion is, while it does double the slash in the link, this appears to be benign and the link still gets to github ok. However, that feels dodgy to me
…scala Added slash on not specified
armanbilge
approved these changes
Sep 15, 2023
|
Applied the desired change (first time using "apply suggestion", that was fun): we now fallback to slash if the patch is not specified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses scala/bug#12867, ensuring that a slash is added for
2.13.12and above (assuming that this will also be the case for2.13.13and2.14.0etc).