Merge pull request #643 from j-mie6/fix/scaladoc-link-2.13.12

Added version bound check and added slash
typelevel · Sep 15, 2023 · 5dec904 · 5dec904
2 parents 66ccffa + f5e0b2f
commit 5dec904
Showing 1 changed file with 18 additions and 13 deletions.
diff --git a/github/src/main/scala/org/typelevel/sbt/TypelevelGitHubPlugin.scala b/github/src/main/scala/org/typelevel/sbt/TypelevelGitHubPlugin.scala
@@ -18,12 +18,12 @@ package org.typelevel.sbt
 
 import com.github.sbt.git.SbtGit.git
 import org.typelevel.sbt.kernel.GitHelper
+import org.typelevel.sbt.kernel.V
 import sbt._
 
 import scala.util.Try
 
 import Keys._
-import TypelevelKernelPlugin.autoImport._
 
 object TypelevelGitHubPlugin extends AutoPlugin {
 
@@ -82,19 +82,24 @@ object TypelevelGitHubPlugin extends AutoPlugin {
       val userRepo = gitHubUserRepo.value
       val infoOpt = scmInfo.value
 
-      if (tlIsScala3.value)
-        tagOrHash.toSeq flatMap { vh =>
-          userRepo.toSeq flatMap {
-            case (user, repo) => Seq(s"-source-links:github://${user}/${repo}", "-revision", vh)
-          }
-        }
-      else
-        tagOrHash.toSeq flatMap { vh =>
-          infoOpt.toSeq flatMap { info =>
-            val path = s"${info.browseUrl}/blob/${vh}€{FILE_PATH}.scala"
-            Seq("-doc-source-url", path)
-          }
+      tagOrHash.toSeq flatMap { vh =>
+        scalaVersion.value match {
+          case V(V(3, _, _, _)) =>
+            userRepo.toSeq flatMap {
+              case (user, repo) =>
+                Seq(s"-source-links:github://${user}/${repo}", "-revision", vh)
+            }
+          case (V(V(2, minor, patch, _))) =>
+            infoOpt.toSeq flatMap { info =>
+              val path =
+                // see https://github.com/scala/bug/issues/12867#issuecomment-1718481858
+                if (minor > 13 || minor == 13 && patch.forall(_ >= 12))
+                  s"${info.browseUrl}/blob/${vh}/€{FILE_PATH}.scala"
+                else s"${info.browseUrl}/blob/${vh}€{FILE_PATH}.scala"
+              Seq("-doc-source-url", path)
+            }
         }
+      }
     }
   )