engageRename cla.yml to cla.ympythonengage #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r#119) * Stop manual URI parsing/escaping and use URI::HTTP standard library. * Update .travis.yml * bump minimum Ruby version * Use CGI::parse - URI::decode_www_form can't handle multibyte characters * avoid using set_form_data() - as it doesn't seem to be escaping some of the special characters such as '*' (asterisk). Use CGI.escape instead. - do not parse/escape request POST body in case if "content-type" request header is specified. * Update .travis.yml - follow latest Ruby releases
* make username option settable on requests twitter#10 * update deprecated name
* Use STDIN.gets for pin prompt * Fix invalid README reference in gemspec
* Add twurl version to user agent header * Add test
* Add Code of Conduct v2.0 from https://github.com/twitter/code-of-conduct/blob/master/code-of-conduct.md * Update LICENSE * Update README
* Add --timeout and --connection-timeout options * Only set max_retries if Ruby version is >= 2.5) * Fix test (random failure) Since the Minitest run tests concurrently, sometimes the "DispatchWithOneAuthorizedAccountTest" class runs after the "DispatchWithOneUsernameThatHasAuthorizedMultipleAccountsTest" run. In this case, "Twurl::OAuthClient.rcfile" has multiple profiles data in there and hence it fails with its mock checks.
* Make aliases work again Closes: twitter#93 * show usage when args are insufficient * Update lib/twurl/cli.rb Co-Authored-By: Shohei Maeda <[email protected]>
* bump version * Handle timeout errors * Fix .gemspec
so users can make a request without ~/.twurlrc file if all options (-c, -s, -a, and -S) are provided.
* Add -j (--json-pretty) option * Fix test not all machines have the "TMPDIR" env variable set by default (e.g., Chrome OS) and hence Minitest actually removes user's "~/.twurlrc" file if the "TMPDIR" is not set. To remediate this, override the directory path in case if it's missing so running tests don't remove the user's file by accident. * Update .gitignore * Update INSTALL remove outdated info and use Markdown * Update INSTALL.md
* Documentation improvements * Adding suggestions from twitter#62 * fixing contributors in readme
* Support Bearer Token * change method name * Add tests * rcfile.bearer_tokens is nil if .twurlrc doesn't exist * Add "oauth2_tokens" command and support --oauth2 with -c option so users can make an OAuth2 request without creating a user profile if they want... (e.g., a user who only use bearer token) * Change "--oauth2" option name to "--bearer" * Fix AppOnlyTokenInformationController * Fix NoMethodError * Update README * Fix Typo
* Add Ruby 2.7.0 to .travis.yml * Update contribute guide
* rubyforge_project option is deprecated * Adding Dockerfile for VSCode remote development * simplify .gemspec
* fix newline in README * fix version in install, add build badge
fix version
* handle invalid option exceptions * deprecate xauth * fix twitter#142 * supress undefined method error twitter#149
and remove a magic comment
* Add GitHub Actions Workflow * Remove Coveralls as it is not being used twitter#161 (comment) * Address changes in RR v3.0.0 Now we need to take the block as a proc, not as an argument. refs: rr/rr@d6da209#diff-a20b4cc1aac26c32a40206ad0776d4ff528201e97b737b7b3f0be1eb0e12e93dL44-L49 * Require RR v3 * Require OpenStruct v0.3.3+ The following test cases fail when running CI in Ruby 3.0. ``` 1) Failure: Twurl::CLI::OptionParsingTest#test_setting_host_updates_to_requested_value [/home/runner/work/twurl/twurl/test/cli_test.rb:214]: Expected: "localhost:3000" Actual: "api.twitter.com" 2) Failure: Twurl::CLI::OptionParsingTest#test_setting_proxy_updates_to_requested_value [/home/runner/work/twurl/twurl/test/cli_test.rb:237]: Expected: "localhost:80" Actual: nil 3) Failure: Twurl::CLI::OptionParsingTest#test_passing_no_ssl_option_disables_ssl [/home/runner/work/twurl/twurl/test/cli_test.rb:196]: Expected false to be truthy. 4) Failure: Twurl::CLI::OptionParsingTest#test_specifying_a_request_method_extracts_and_normalizes_request_method [/home/runner/work/twurl/twurl/test/cli_test.rb:54]: Expected: "put" Actual: "get" 5) Failure: Twurl::CLI::OptionParsingTest#test_protocol_is_stripped_from_host [/home/runner/work/twurl/twurl/test/cli_test.rb:221]: Expected: "localhost:3000" Actual: "api.twitter.com" 6) Failure: Twurl::CLI::OptionParsingTest#test_passing_data_and_an_explicit_request_method_uses_the_specified_method [/home/runner/work/twurl/twurl/test/cli_test.rb:148]: Expected: "delete" Actual: "post" 7) Failure: Twurl::Options::Test#test_ssl_is_enabled_if_the_protocol_is_https [/home/runner/work/twurl/twurl/test/cli_options_test.rb:18]: Expected false to be truthy. 8) Failure: Twurl::Options::Test#test_base_url_is_built_from_protocol_and_host [/home/runner/work/twurl/twurl/test/cli_options_test.rb:13]: Expected: "http://api.twitter.com" Actual: "https://api.twitter.com" ``` According to twitter#159 (comment), the cause appears to be a bug in OpenStruct. The bug was fixed in ruby/ostruct#23, and released as v0.3.3. * Drop support for Ruby 2.4 - OpenStruct v0.3.3+ requires Ruby 2.5+. - It's already reached EOL on 2020-03-31. * Migrate CI from Travis CI to GitHub Actions
* update VSCode remote container settings Use docker-compose and mount volume between host and container properly * "-v" option to include Ruby runtime version * Support of Ruby 2.4 has ended https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/ * twitter#157 fix parse rule and better error message * remove --no-ssl option * do not allow alias to use reserved command names * max_retries is available since Ruby 2.5 and now we require spec.required_ruby_version = '>= 2.5.0' so no need to have this condition anymore * don't exit * --raw-data option is fake Although the description says "Sends the specified data as it is..." it's actually parsing input data using CGI.parse() method. This isn't ideal, especially when sending JSON data, for instance. This commit changes this behavior and makes that option a real thing, so users can also send JSON data using -r option by setting the content-type request header using -A option. For backword-compatibility, we still allow -d option to send JSON data as long as "content-type: application/json" request header is set. Also, since -r takes input data as-is, it doesn't really make sense to allow combine use with -d option or adding -r option more than once, so we treat them as an error going forward. * error message should use Exception over CLI.puts * workaround for OpenStruct bug in Ruby 3.0.0 This commit can be reverted once new Ruby 3 patch/minor version has released. * update .travis.yml * remove coveralls * Revert "workaround for OpenStruct bug in Ruby 3.0.0" see twitter#173 * Update devcontainer.json * prevent panic message on Ctrl-C in PIN auth flow
|
|
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Explain the context and why you're making that change. What is the
problem you're trying to solve? In some cases there is not a problem
and this can be thought of being the motivation for your change.
Solution
Describe the modifications you've done.
Result
What will change as a result of your pull request? Note that sometimes
this section is unnecessary because it is self-explanatory based on
the solution.