Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/accessibility check #403

Open
wants to merge 161 commits into
base: main
Choose a base branch
from

Conversation

SamanthaMcElhinney
Copy link

Types of changes made?

  • Refactor HTML

What does this PR do?

  • Refactors naming of alt/ images and fixes structural elements following WAVE accessibility check. The app is now 94% accessible following the Lighthouse Audit with contrast errors we can look at tomorrow.

Relevant Tickets?

  • WAVE accessibility check

Questions/Comments/Relevant Screenshots?

I attached the contrast errors while running the accessibility check
Screen Shot 2023-04-02 at 6 37 07 PM

hjawad22 and others added 30 commits March 27, 2023 15:56
Add base framework and tests for hydration class
…lating the average step goal of all users in the repository.
…ke in the array of objects and create method to calculate average fluid per user
[Feature] Average User Step Goals, User Repository Test Data File, User Repo Tests
…ep goal of all users; fetches user data from the API provided, and adds some sections to the scripts file for organization.
…lcuate-users-average

Feature/hydration class calcuate users average
[Feature] User Data DOM Manipulation Framework and User API Fetch
Add functions for seeing ounces consumed by user and testing of those…
SamanthaMcElhinney and others added 30 commits April 1, 2023 14:27
…-activity-class

Feature/refactor hydration activity class
… using new returnUserNames method, creates new DOM manipulation functions for broken-out profile sections and adds classes.
…ate from Nav bar and interpolates in a dynamic day and date string using day.js.
[Feature] User Profile Card Initial Design
Add set up activity button with styling
…es containers to better make use of flex properties, ensures page fits within window, adjusts relative sizing of objects and introduces a degree of responsiveness.
[Fix] DOM Manipulation Functions and Charts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants