-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/accessibility check #403
Open
SamanthaMcElhinney
wants to merge
161
commits into
turingschool-examples:main
Choose a base branch
from
JWFeatherstone:refactor/accessibility-check
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor/accessibility check #403
SamanthaMcElhinney
wants to merge
161
commits into
turingschool-examples:main
from
JWFeatherstone:refactor/accessibility-check
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add base framework and tests for hydration class
…lating the average step goal of all users in the repository.
Feature/user class
…ke in the array of objects and create method to calculate average fluid per user
[Feature] Average User Step Goals, User Repository Test Data File, User Repo Tests
…ep goal of all users; fetches user data from the API provided, and adds some sections to the scripts file for organization.
…lcuate-users-average Feature/hydration class calcuate users average
…tion-test.js file
[Feature] User Data DOM Manipulation Framework and User API Fetch
Add functions for seeing ounces consumed by user and testing of those…
…-activity-class Feature/refactor hydration activity class
… using new returnUserNames method, creates new DOM manipulation functions for broken-out profile sections and adds classes.
…ate from Nav bar and interpolates in a dynamic day and date string using day.js.
[Feature] User Profile Card Initial Design
[Feature] User Welcome Formatting
…-sam-john into feature/stat-cards-css
Feature/stat cards css
Add set up activity button with styling
Feature/css
…move hydration and user data files
Feature/random users and date
…es containers to better make use of flex properties, ensures page fits within window, adjusts relative sizing of objects and introduces a degree of responsiveness.
[Feature] CSS Alignment and Sizing
[Fix] DOM Manipulation Functions and Charts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes made?
What does this PR do?
Relevant Tickets?
Questions/Comments/Relevant Screenshots?
I attached the contrast errors while running the accessibility check