Pull Request: Basic/Advanced Distinction + Examples Estimation Section Additions and Changes #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s contains juice_orbital_phase.py . Merge branch 'feature/my_juice_examples' into luigi_examples
… retrieve Ganymede's radius and grav. parameter GM.
…ulti_arc strategy.
… empirical accelerations definition.
…ice_orbital_phase.py'
…formal errors matrix and covariance matrix ellipsoids.
…2) estimated parameters (added ground station pos and empirical acceleration); 3) added some additional explanations to plots
…rs, updated the corresponding .py)
…rs, updated the corresponding .py)
…rs, updated the corresponding .py)
…e.ipynb and converted into a (working) python script
…ers (delfi c3 covariance analysis example). Deleted it from full_estimation_example.py
…R retrieving PSEUDO MPC and JUICE ORBITAL PHASE, BECAUSE THOSE ARE FOUND IN THEIR RESPECTIVE BRANCHES, as well as the PROPAGATION OF COVARIANCE EXAMPLE) in the estimation folder example. 2) Re-formulated all jupyter notebook intros, adding the objectives. 3) added some links and/or references in the notebooks, whenever needed.
…into a python file.
…d covariance_propagation_example.ipynb
|
@luigigisolfi Could you split this into two separate PRs?
|
|
Hi Dominic! Yes, will do!
(The original workflow was indeed divided in two branches. The commented
juice example is in feature/my_juice_example branch, later merged into
luigi_examples)
Ciao
Luigi
Il mer 4 set 2024, 19:21 DominicDirkx ***@***.***> ha scritto:
… @luigigisolfi <https://github.com/luigigisolfi> Could you split this into
two separate PRs?
- One for the JUICE example
- One for everything else
I have a bunch of comments on the JUICE example, and I'd like to take
some time to revised/modify some things, but the rest can be merged more
quickly I think. In general, for different (groups of) features it's best
to have a separate PR (and no, I don't always stick to this either :) )
—
Reply to this email directly, view it on GitHub
<#55 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBW3WYHF23DMGDLKOR5RKRTZU46R5AVCNFSM6AAAAABNSVCLNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRZGYYDKOJSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thanks! Could you close this PR, and give the other two clear titles/descriptions that are independent of this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request copied from: #51, but without the basic/advanced split
Some additions include:
To be fixed:
mars express example outputs are different from the ones currently shown on the tudat website