Finish Number::SameValue #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
requested changes
Oct 31, 2023
…nd clarify comment
ghost
commented
Oct 31, 2023
ghost
commented
Oct 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes a
todocomment inNumber::isreferring to the spec forObject.is.Object.isis implemented viaSameValue(x, y), which in turn has a separate branch for numbers:Number::SameValue.This is the rest of the implementation.
I also identified that
Number::iswas being used in places where the spec wanted pretty much simple equality, as opposed toSameValue? Although they would both fit.We should try to get some helpers for comparisons and operations soon, the code is overtly verbose. I'll write some ideas on the Discord server.