Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add license #286

Merged
merged 6 commits into from
Jul 8, 2024
Merged

chore: Add license #286

merged 6 commits into from
Jul 8, 2024

Conversation

aapoalas
Copy link
Collaborator

@aapoalas aapoalas commented Jul 7, 2024 •
edited
Loading

This PR finally adds a license, the MPLv2.0. This license has a few nice properties:

  1. It's copyleft, but weak. This is very acceptable to companies but it does require any modifications to also be MPL2 or GPL, so this is not a "take and make it all proprietary" license.
  2. It has a builtin contributor license agreement (hence why everyone's a reviewer).
  3. It has a builtin patent troll protection.

@aapoalas aapoalas marked this pull request as ready for review July 7, 2024 19:56
@aapoalas
Copy link
Collaborator Author

aapoalas commented Jul 7, 2024

@lino-levan & @load1n9 I can't add you as reviewers for some reason but you also have commits, so an approval from you would also be nice :)

@load1n9
Copy link
Member

load1n9 commented Jul 7, 2024

LGTM

andreubotella
andreubotella approved these changes Jul 7, 2024
View reviewed changes
Copy link
Collaborator

@andreubotella andreubotella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Btw, we'd also need to make sure vimirage is okay with this change of license, which might be hard since it seems they deleted their Github and Discord accounts. Does anyone have any way of contacting them?

@sno2

This comment was marked as resolved.

Sign in to view
@andreubotella
Copy link
Collaborator

I don't believe any of their contributions were ever merged.

Yes they were: #49, #51, #52, #72. They also proposed changes that were accepted in PRs #50, #53 and #63, although those might not count as significant for copyright purposes.

@sno2
Copy link
Contributor

sno2 commented Jul 7, 2024

Oh, thank you for checking. My bad.

lino-levan
lino-levan approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@lino-levan lino-levan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MierenManz
MierenManz approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@MierenManz MierenManz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@aapoalas aapoalas merged commit a70f9dd into main Jul 8, 2024
1 check passed
@aapoalas aapoalas deleted the license branch July 8, 2024 06:44
@sno2
Copy link
Contributor

sno2 commented Jul 8, 2024

Phosra consented to the licensing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MierenManz MierenManz MierenManz approved these changes

@sno2 sno2 sno2 approved these changes

@eliassjogreen eliassjogreen eliassjogreen approved these changes

@lino-levan lino-levan lino-levan approved these changes

@andreubotella andreubotella andreubotella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aapoalas @load1n9 @sno2 @andreubotella @lino-levan @eliassjogreen @MierenManz