Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add recent contributors #2653

Merged
merged 6 commits into from
Nov 14, 2023
Merged

chore: Add recent contributors #2653

merged 6 commits into from
Nov 14, 2023

Conversation

brandonlenz
Copy link
Contributor

Summary

Several recent contributors need to be added to our all-contributors

@aybeedee @m7adeel @vinodkv2511 if you do not want to be in our all-contributors section of the README, please tag me in a comment on this PR. Otherwise, We'll merge this sometime next week. Thanks for your recent help!

@brandonlenz brandonlenz requested a review from a team as a code owner November 4, 2023 02:06
@brandonlenz brandonlenz changed the title chore(contributors): Add recent contributors chore: Add recent contributors Nov 4, 2023
@brandonlenz
Copy link
Contributor Author

Note to self, after merging this, check and see if the bot works again.

If it does, the issue was that commitType cannot include a scope, and this issue needs to be updated to let the maintainers know where to add more specific error handling.

And perhaps an additional issue to allow scope in https://github.com/Berkmann18/commit-conv

Copy link
Contributor

@kleinschmidtj kleinschmidtj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonlenz brandonlenz enabled auto-merge (squash) November 14, 2023 16:21
@brandonlenz brandonlenz merged commit 306daaa into main Nov 14, 2023
8 checks passed
@brandonlenz brandonlenz deleted the bl-add-recent-contributors branch November 14, 2023 16:26
@brandonlenz
Copy link
Contributor Author

@all-contributors please add @kleinschmidtj for code

Copy link
Contributor

@brandonlenz

I've put up a pull request to add @kleinschmidtj! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants