-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve bot error messaging on invalid commitType config (Example inside) #485
Comments
It seems I've just hit the same issue here. |
@nicrie I have a hunch that this will fix it for me: Looking at your config file, it won't be the same resolution for you. That said, if this does fix it for me I will update this issue to request error handling around the culprit so that the error messaging can be improved. |
Implement solution suggested in all-contributors/app#485
Thanks for the hint, @brandonlenz. How do you know that the |
Indeed it fixed it: trussworks/react-uswds#2653 (comment). Updating issue. |
I didn't know it would fix it, but I had a guess. I had to look at the underlying libraries used by the bot to see that my |
Describe the bug
When fed a valid request, the bot says it is unable to process the request:
trussworks/react-uswds#2618 (comment)
This was due to the repository config using a commitType that also included a scope. Reverting the scope fixed the issue:
trussworks/react-uswds#2653 (comment)
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The bot should properly create the contributor PR
OR
The bot should indicate what the problem is, in this case, specifically handling an error that I assume bubbles up from https://github.com/Berkmann18/commit-conv
Additional
Opened an issue with commit-conv: Berkmann18/commit-conv#35 to allow scope.
The text was updated successfully, but these errors were encountered: