Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bot error messaging on invalid commitType config (Example inside) #485

Open
brandonlenz opened this issue Oct 18, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@brandonlenz
Copy link

brandonlenz commented Oct 18, 2023

Describe the bug
When fed a valid request, the bot says it is unable to process the request:

trussworks/react-uswds#2618 (comment)

image

This was due to the repository config using a commitType that also included a scope. Reverting the scope fixed the issue:

image

trussworks/react-uswds#2653 (comment)

To Reproduce
Steps to reproduce the behavior:

  1. Create a repo with an all contributors config file that includes commitType: "chore(someScope)"
  2. Try to use the bot
  3. Note that it fails. The error sounds like it is network, API, or all-contributors code related. I suspect since it works for others (presumably) that there is actually an issue with our repo or configuration. Note that the bot used to work in this repo.

Expected behavior
The bot should properly create the contributor PR

OR

The bot should indicate what the problem is, in this case, specifically handling an error that I assume bubbles up from https://github.com/Berkmann18/commit-conv

Additional

Opened an issue with commit-conv: Berkmann18/commit-conv#35 to allow scope.

@nicrie
Copy link

nicrie commented Nov 14, 2023

It seems I've just hit the same issue here.

@brandonlenz
Copy link
Author

@nicrie I have a hunch that this will fix it for me:
https://github.com/trussworks/react-uswds/pull/2653/files#diff-cb22095514d0cab1f755ae3a7902f7d64d10199da210fbd1eb2b29eb758b38d2R223
image

Looking at your config file, it won't be the same resolution for you.

That said, if this does fix it for me I will update this issue to request error handling around the culprit so that the error messaging can be improved.

nicrie added a commit to xarray-contrib/xeofs that referenced this issue Nov 14, 2023
@nicrie
Copy link

nicrie commented Nov 14, 2023

Thanks for the hint, @brandonlenz. How do you know that the commitType will solve it for you? I still tried your solution myself, but - as you already indicated - to no avail.

@brandonlenz
Copy link
Author

Indeed it fixed it: trussworks/react-uswds#2653 (comment).

Updating issue.

@brandonlenz brandonlenz changed the title Bot unable to process requests Improve bot error messaging on invalid config (Example inside) Nov 14, 2023
@brandonlenz
Copy link
Author

Thanks for the hint, @brandonlenz. How do you know that the commitType will solve it for you? I still tried your solution myself, but - as you already indicated - to no avail.

I didn't know it would fix it, but I had a guess. I had to look at the underlying libraries used by the bot to see that my commitType configuration was likely invalid. The other hint was the bot stopped working after that was added to our repo's config.

@brandonlenz brandonlenz changed the title Improve bot error messaging on invalid config (Example inside) Improve bot error messaging on invalid commitType config (Example inside) Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants