Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps-dev): Bump @uswds/uswds from 3.1.0 to 3.4.1 #2305

Merged
merged 4 commits into from
Jul 31, 2023
Merged

build(deps-dev): Bump @uswds/uswds from 3.1.0 to 3.4.1 #2305

merged 4 commits into from
Jul 31, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 20, 2023 •
edited
Loading

Bumps @uswds/uswds from 3.1.0 to 3.4.1.

Release notes

Sourced from @​uswds/uswds's releases.

USWDS 3.4.1

What's new in USWDS 3.4.1

There were a couple features and bug fixes that we intended to include in USWDS 3.4.0, but inadvertently omitted from that release.

Features and bug fixes

Type Package A11y Breaking Description
Feature usa-in-page-navigation —  — Update the URL in the address bar when navigating from the In-Page Navigation. Now users can see the proper anchor link in the address bar when navigating. Thanks @​aduth! (uswds/uswds#5068)
Bug usa-form — — Fixed invisible link text for links styled as buttons within forms. Now link text does not match the primary button color when nested inside of a form and the usa-button class is present. (uswds/uswds#5112)
Bug usa-header — —  Logo text width setting now works as expected. Now the design system respects the value passed to $theme-header-logo-text-width. Thanks @​RSD-accessboard! (uswds/uswds#5008)

Dependencies and security

No dependency changes

0 vulnerabilities in regular dependencies (dependencies for USWDS projects installed with npm install uswds)

1 moderate 33 high vulnerabilities in devDependencies (development dependencies)

Release TGZ SHA-256 hash: af1cd42c60b73fbbfa9c27b8ee52fb735b1a2234c6b3aa17de5bbf8a9190ca62

USWDS 3.4.0

What’s new in USWDS 3.4.0

Features and bug fixes

Type Package A11y Breaking Description
Feature usa-banner —  —  Remove grid dependency from Banner package. Now you no longer need to use the usa-layout-grid package with usa-banner resulting in a much smaller package size. (uswds/uswds#5000)
Feature uswds-core —  Maybe  Output only the modern woff2 font format, unless you need compatibility. Now we output only the woff2 webfont format with our default settings. Since we no longer support IE11 and other old browsers, we no longer need to serve the woff and ttf formats. Teams that need this support can activate it with a new setting: $theme-font-browser-compatibility: true. This is only a breaking change if your project needs to support IE11. (uswds/uswds#5108)
Feature usa-header — —  Allow full-page width for the header. You can now set a value of "none" for any max-width setting, including $theme-header-max-width. (uswds/uswds#5072)
Feature usa-in-page-navigation —  — Update the URL in the address bar when navigating from the In-Page Navigation. Now users can see the proper anchor link in the address bar when navigating. Thanks @​aduth! (uswds/uswds#5068)
Bug fix usa-alert uswds-core —  —  Set padding to any valid spacing token. Now you can use valid values like 1.5 for $theme-alert-padding-y. Thanks @​aduth! (uswds/uswds#5076)
Bug fix usa-banner Yes — Improved display of focus outline on mobile. Now the focus outline is visible all around the banner on mobile devices. Thanks @​jhancock532! (uswds/uswds#5013)
Bug fix usa-footer Yes — Use any heading level for the primary links header. Now if you use any heading level for .usa-footer__primary-link without it reverting to an h4 when the JavaScript rebuilds the element for mobile. Thanks @​paulathevalley! (uswds/uswds#5044)
Bug fix usa-header Yes —  Secondary nav is now read properly on screen readers. The separator between nav elements is no longer read on screen readers. (uswds/uswds#4963)
Bug fix usa-link —  —  External link icons and link text now wrap as expected. Now external links break over wrapped lines as expected in any browser. (uswds/uswds#5046)
Bug fix usa-modal — —  Interactive form elements like Date Picker now work properly in a modal window. Now any element in a modal should work as expected. (uswds/uswds#5049)
Bug fix usa-step-indicator Yes —  More legible contrast on pending items. Graphical elements related to pending items now meet accessibility standards for contrast ratio. (uswds/uswds#5048)
Bug fix uswds-utilities uswds-core —  —  Outline utility and mixin now accept the 05 token. Now, the .outline-05 utility class and the u-outline('05') mixin should work as expected. (uswds/uswds#5079)
Content — —  —  Improved copy in 404 template. We updated the 404 page template copy to follow parallel structure and use active voice. Thanks @​ybom for the Spanish translation! (uswds/uswds#5045)
Guidance — —  —  Expanded and improved our Gender Identity and Sex patterns. We've made updates to our pattern guidance and our pattern previews to help provide more practical use cases and up-to-date guidance for these patterns. For more details, see uswds/uswds-site#1994

Dependencies and security

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added type: automerge PR will be merged automatically i.e., by a bot or action type: dependencies Maintaining 3rd-party dependencies labels Mar 20, 2023
@dependabot dependabot bot requested review from ahobson and haworku March 20, 2023 06:00
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 20, 2023
View reviewed changes
@dependabot dependabot bot mentioned this pull request Mar 20, 2023
Closed
@dependabot dependabot bot force-pushed the dependabot-npm_and_yarn-uswds-uswds-3.4.1 branch from f8ed166 to 462981b Compare March 20, 2023 06:09
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 20, 2023
View reviewed changes
@dependabot dependabot bot force-pushed the dependabot-npm_and_yarn-uswds-uswds-3.4.1 branch from 462981b to 85f888d Compare March 20, 2023 06:16
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 20, 2023
View reviewed changes
@dependabot dependabot bot force-pushed the dependabot-npm_and_yarn-uswds-uswds-3.4.1 branch from 85f888d to 0098580 Compare March 20, 2023 06:27
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 20, 2023
View reviewed changes
@dependabot
build(deps-dev): Bump @uswds/uswds from 3.1.0 to 3.4.1
1ae9aed 
Bumps [@uswds/uswds](https://github.com/uswds/uswds) from 3.1.0 to 3.4.1.
- [Release notes](https://github.com/uswds/uswds/releases)
- [Commits](uswds/uswds@v3.1.0...v3.4.1)

---
updated-dependencies:
- dependency-name: "@uswds/uswds"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot-npm_and_yarn-uswds-uswds-3.4.1 branch from 0098580 to 1ae9aed Compare March 20, 2023 06:35
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 20, 2023
View reviewed changes
@kodiakhq kodiakhq bot removed the type: automerge PR will be merged automatically i.e., by a bot or action label Mar 20, 2023
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Mar 20, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the type: automerge label.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 12, 2023

A newer version of @​uswds/uswds exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@kleinschmidtj kleinschmidtj mentioned this pull request Jul 20, 2023
Closed
@werdnanoslen werdnanoslen requested a review from gidjin July 20, 2023 22:07
This was referenced Jul 26, 2023
Merged
Merged
@werdnanoslen werdnanoslen mentioned this pull request Jul 25, 2023
Merged
jcbcapps
jcbcapps reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@jcbcapps jcbcapps left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed Happo and everything looks good except for Alert with CTA. Not sure if this is expected?
Screenshot 2023-07-31 at 12 32 40 PM

@werdnanoslen
Copy link
Contributor

werdnanoslen commented Jul 31, 2023 •
edited
Loading

I reviewed Happo and everything looks good except for Alert with CTA. Not sure if this is expected? Screenshot 2023-07-31 at 12 32 40 PM

It seems this was intentional to match the site-alert spacing, as seen here. If, in our storybook on this branch, you use the Docs tab or resize the window you'll see that at a narrow enough width (i.e. what usually matches the width of page content, where this'd appear) it continues to look as it did before this bump.

So I think this the Happo diff is good to approve & merge this PR

@jcbcapps jcbcapps merged commit e2bde37 into main Jul 31, 2023
5 checks passed
@jcbcapps jcbcapps deleted the dependabot-npm_and_yarn-uswds-uswds-3.4.1 branch July 31, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcbcapps jcbcapps jcbcapps left review comments

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

@ahobson ahobson Awaiting requested review from ahobson

@haworku haworku Awaiting requested review from haworku

@gidjin gidjin Awaiting requested review from gidjin

Assignees
No one assigned
Labels
type: dependencies Maintaining 3rd-party dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@werdnanoslen @jcbcapps @kleinschmidtj