Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changed template links to buttons #2526

Merged
merged 9 commits into from
Oct 5, 2023
Merged

Conversation

werdnanoslen
Copy link
Contributor

@werdnanoslen werdnanoslen commented Jul 25, 2023

Summary

Changed links to buttons in signin templates.

Related Issues or PRs

Resolves #2508

How To Test

Open the signin 'form' template and signin 'page' template

Screenshots (optional)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023

Warnings
⚠️ This PR does not include changes to tests, even though it affects source code.

Generated by 🚫 dangerJS against 9f9d03b

@werdnanoslen
Copy link
Contributor Author

Happo diff is due to changing to a button instead of link. While not necessarily intended, it doesn't meaningfully affect the story

@shkeating
Copy link
Contributor

only thing I noticed of note, is that the link under the form field is getting kicked down and it does not match what the component looks like in its USWDS original state. I would suggest removing some of the padding/margin from the top to put it back to position.

@werdnanoslen
Copy link
Contributor Author

werdnanoslen commented Oct 5, 2023

Fixed. The very slight (like 1-2px) happo diffs I self-approved seem to be from changes to the uswds class, as it's otherwise implemented exactly the same as the source.

@werdnanoslen werdnanoslen merged commit a4b8423 into main Oct 5, 2023
5 checks passed
@werdnanoslen werdnanoslen deleted the an-password-2508 branch October 5, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Update markup for show password links
4 participants