Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Partial fix for L0_https #810

Merged
merged 2 commits into from
Nov 21, 2024
Merged

fix: Partial fix for L0_https #810

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20bd3ae
Upgrade geventhttpclient version
yinggeh Nov 20, 2024
b6e1465
Set upper bound to geventhttpclient version
yinggeh Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/python/library/requirements/requirements_http.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

aiohttp>=3.8.1,<4.0.0
geventhttpclient>=1.4.4,<=2.0.2
geventhttpclient>=2.0.11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question: is there a version between > 2.0.2 and < 2.0.11 that can run on Python 3.12 but does not have the issue that you are facing?

maybe we should set a max bound, i.e. <2.1.0, to avoid accidental breakages on newer releases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. 2.0.11 is the minimum version to support python3.12 and the issue was introduced in 2.0.4.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to set a upper bound. For geventhttpclient we have 2.0.11, 2.0.12, 2.1.1, 2.2.0, 2.2.1, 2.3.0, 2.3.1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmccorm4 Do you think we should fix the version to 2.0.11 or set a upper bound, e.g. 2.1.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think upper bound is fine following the convention of our other dependencies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

numpy>=1.19.1,<2
python-rapidjson>=0.9.1
Loading