Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Partial fix for L0_https #810

Merged
merged 2 commits into from
Nov 21, 2024
Merged

fix: Partial fix for L0_https #810

merged 2 commits into from
Nov 21, 2024

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Nov 20, 2024 •
edited
Loading

What does the PR do?

Partially fix L0_https--base by upgrading geventhttpclient version to support Python3.12 on Ubuntu 24.04.
"Try with incorrect key" tests are still failing because of changes in geventhttpclient newer version.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • fix

Related PRs:

Where should the reviewer start?

Test plan:

  • CI Pipeline ID:
    20604304

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@yinggeh yinggeh requested review from rmccorm4 and mc-nv November 20, 2024 21:49
@yinggeh yinggeh self-assigned this Nov 20, 2024
@yinggeh yinggeh changed the base branch from main to r24.11 November 20, 2024 21:50
@yinggeh yinggeh changed the title fix: Partially fix L0_https fix: Partial fix for L0_https Nov 20, 2024
kthui
kthui reviewed Nov 21, 2024
View reviewed changes
src/python/library/requirements/requirements_http.txt Outdated
@@ -25,6 +25,6 @@
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

aiohttp>=3.8.1,<4.0.0
geventhttpclient>=1.4.4,<=2.0.2
geventhttpclient>=2.0.11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question: is there a version between > 2.0.2 and < 2.0.11 that can run on Python 3.12 but does not have the issue that you are facing?

maybe we should set a max bound, i.e. <2.1.0, to avoid accidental breakages on newer releases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. 2.0.11 is the minimum version to support python3.12 and the issue was introduced in 2.0.4.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to set a upper bound. For geventhttpclient we have 2.0.11, 2.0.12, 2.1.1, 2.2.0, 2.2.1, 2.3.0, 2.3.1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmccorm4 Do you think we should fix the version to 2.0.11 or set a upper bound, e.g. 2.1.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think upper bound is fine following the convention of our other dependencies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@yinggeh yinggeh requested a review from kthui November 21, 2024 01:23
@yinggeh yinggeh added the bug Something isn't working label Nov 21, 2024
@yinggeh yinggeh merged commit 1ad7d98 into r24.11 Nov 21, 2024
3 checks passed
@yinggeh yinggeh deleted the yinggeh-DLIS-7613-fix-L0-https branch November 21, 2024 22:12
mc-nv pushed a commit that referenced this pull request Nov 22, 2024
@yinggeh @mc-nv
fix: Partial fix for L0_https (#810)
e996a60
mc-nv added a commit that referenced this pull request Nov 26, 2024
@mc-nv @nv-anants @yinggeh
Update main branch post 24.11 (#812)
76e15f2 
* Build Updates for Ubuntu24.04 (#802) (#805)

* update cmake version

* include patch version in cmake install

Co-authored-by: Anant Sharma <[email protected]>

* Hotfix for java (#808)

* Prevent failure if cache is empty (#809)

* Lock grpcio version (#811)

* fix: Partial fix for L0_https (#810)

* Fix L0_https--base SSL issue (#813)

* Upgrade geventhttpclient version to 2.3.2

* Upgrade geventhttpclient to latest version

---------

Co-authored-by: Anant Sharma <[email protected]>
Co-authored-by: Yingge He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishung5 krishung5 krishung5 approved these changes

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@mc-nv mc-nv Awaiting requested review from mc-nv

@kthui kthui Awaiting requested review from kthui

Assignees

@yinggeh yinggeh

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yinggeh @kthui @rmccorm4 @krishung5