LLM Inputs Library - MVP #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
debermudez
reviewed
Mar 1, 2024
tgerdesnv
reviewed
Mar 1, 2024
| if model_name: | ||
| pa_json["data"][0]["payload"][index]["model"] = model_name | ||
| if add_streaming: | ||
| pa_json["data"][0]["payload"][index]["streaming"] = "true" |
There was a problem hiding this comment.
I told you wrong. It is supposed to be "stream", not "streaming"
https://platform.openai.com/docs/api-reference/chat/create#chat-create-stream
| DEFAULT_LENGTH = 100 | ||
| MINIMUM_LENGTH = 1 | ||
|
|
||
| EMPTY_JSON_IN_PA_FORMAT = {"data": [{"payload": []}]} |
There was a problem hiding this comment.
FYI the payload key is only true for OpenAI
There was a problem hiding this comment.
Changed name to reflect this
tgerdesnv
reviewed
Mar 1, 2024
There was a problem hiding this comment.
This looks fine for HuggingFace->OpenAI format. There will need to be some refactoring in order to support the following:
HuggingFace->Triton_Trtllm
Synthetic->OpenAI
Synthetic->Triton_Trtllm
We probably also need Triton_vllm. I think that's 99% the same as Triton_trtllm though
debermudez
approved these changes
Mar 1, 2024
debermudez
pushed a commit
that referenced
this pull request
Mar 12, 2024
* Initial code for LLmInputs methods. All unit tests passing. * Ensure file is deleted and general cleanup * Adding in missing parameter descriptions * Removing uneeded import * Fixing precommit issues * Fixing codeQL issue * Fixing more codeQL issues * Removing datasets dependency * Changes based on Elias' review * Fixing precommit error * Fixing names
debermudez
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Initial code for LLmInputs methods. All unit tests passing. * Ensure file is deleted and general cleanup * Adding in missing parameter descriptions * Removing uneeded import * Fixing precommit issues * Fixing codeQL issue * Fixing more codeQL issues * Removing datasets dependency * Changes based on Elias' review * Fixing precommit error * Fixing names
mc-nv
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Initial code for LLmInputs methods. All unit tests passing. * Ensure file is deleted and general cleanup * Adding in missing parameter descriptions * Removing uneeded import * Fixing precommit issues * Fixing codeQL issue * Fixing more codeQL issues * Removing datasets dependency * Changes based on Elias' review * Fixing precommit error * Fixing names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a library with a single method
create_openai_llm_inputs.Unit testing is in place to cover private methods as well as an end-to-end test that checks both open_orca and cnn_dailymail.