feat: inlay hints #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tris203
commented
May 25, 2024
|
@willothy can you give this one a look over as there is a lot here i think its good to go though |
|
I'll look this over tomorrow! |
willothy
previously requested changes
May 31, 2024
| local M = {} | ||
|
|
||
| function M.inlay_hints_enabled(t) | ||
| if vim.lsp and vim.lsp.inlay_hint and vim.lsp.inlay_hint.is_enabled then |
There was a problem hiding this comment.
Couldn't you use has("nvim-0.10") here?
There was a problem hiding this comment.
If this isn't a big deal then this PR is good to merge once conflicts are handled imo :)
There was a problem hiding this comment.
I need to rebase and will check the field name. I know the lsp API changed a few times in 0.10. I can't remember which released
I will check docs tomorrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs:
Test WS offsetoffsets need some adjustments as on complex lines they get messed upCloses #37