-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any way to make it adjust to inlay hints #37
Comments
I haven't used inlay hints much at all, but I have just had a look at the API and I think this should be possible. I should be able to hook the inlay hints and inject the same amount of space into the string. I will have a play with a PoC later Thanks for the report, I imagine there are going to be a few cases like this with different configs! |
This would be cool! Great idea now that 0.10 is released. |
I have an experimental implementation of this in #38 @luispinto23 would you be able to give it some testing? |
I'd love to help, but I'm off for the weekend with no PC. |
Thanks @luispinto23 that would be great It seems to work for me, but I don't use inlay hints regularly so it won't get tested much more. The PR needs actually tests before it can be merged. And Mac CI hasn't been updated to 0.10 yet. So a merge will be pending that anyways |
Hi @luispinto23 Change the commit line to Then open You will need to remove that line and reupdate when the change is merged I think it should work fine, I have done more on this tonight and it seems to be working well |
Brilliant I will try and get the testing strategy fleshed out Thanks for your assistance @luispinto23 I have my GitHub sponsors set up if you wanted to, but it's really not necessary |
I tested this out as well today and lgtm. |
First of all, thank you for this amazing plugin.
I am having a small problem though, I have lsp inlay hints active and this messes up with the plugin. Is there anyway to make it work with inlay hints?
example:
The text was updated successfully, but these errors were encountered: