Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] native Fortran pointer conversion to/from arrayview #217

Closed
wants to merge 6 commits into from

Conversation

sethrj
Copy link
Collaborator

@sethrj sethrj commented Feb 20, 2018

This allows Teuchos::ArrayView<T> to replace current uses of std::pair<T*, size_t>.

WIP because the code is untested because I'm working on a different branch of SWIG at the moment. If you'd like to make sure the code works, go ahead and work on this branch, or let me know if you want to wait and I will test/integrate later.

Closes #163

@sethrj sethrj requested a review from aprokop February 20, 2018 16:35
@sethrj sethrj changed the base branch from master to develop February 20, 2018 16:35
@codecov-io
Copy link

codecov-io commented Feb 20, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@f25352a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop    #217   +/-   ##
=========================================
  Coverage           ?   37.5%           
=========================================
  Files              ?      33           
  Lines              ?   13586           
  Branches           ?       0           
=========================================
  Hits               ?    5096           
  Misses             ?    8490           
  Partials           ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f25352a...fe194d9. Read the comment docs.

@aprokop
Copy link
Collaborator

aprokop commented Feb 20, 2018

I will have to wait as a) this is not a high priority, and b) I currently don't have time to work on it.

@aprokop aprokop changed the base branch from develop to master June 7, 2018 15:03
@sethrj
Copy link
Collaborator Author

sethrj commented Feb 4, 2019

Superseded by #261

@sethrj sethrj closed this Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants