-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Upgrade ForTrilinos and enable TpetraOperator derived type #221
Conversation
cceed82
to
cca0c66
Compare
@aprokop To get the builds to pass, unfortunately you'll have to remove the
This error is bogus, and is being fixed in the latest GCC, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84924 . But it'll be a while before any compiler sees that fix. |
Hmm, it explains the gcc failure. Flang compiles fine, but the failure of the test is probably due to missing functionality. |
I'd like to keep the flag to make sure we don't accidentally use any Fortran 2008 features. Ideally, the gcc folks would backport the patch into older compiler versions. But a) it unclear whether that would be done, and b) it may take a long time to get it to Ubuntu. I could switch to one of the recent gcc's once the patch is upstream. Should be easy with Spack. In the mean time, I probably need to follow @sethrj' advice and disable the flag. If I recall correctly, Flang just outright ignores that flag anyway. |
FWIW I'm continuing to build the SWIG test suite with |
All the useful parts of this have been incorporated into master. |
This is an initial implementation of the callback functionality for the Tpetra operator. I've included a skeleton for a unit test that demonstrates its use. This MR supersedes #220 , most of #207 (aside from the int/logical type conversions), and the largest parts of #217.
Closes #163, #177, #185, #219