Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rate limiting to the bastion feeder #233

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

AlCutter
Copy link
Contributor

@AlCutter AlCutter commented Jun 25, 2024

This PR adds support for a configurable rate limiter to control incoming requests from the bastion.

For now, we'll just have a "global" rate limit per bastion, but if needed we can make this richer to support per log limits later.

Towards transparency-dev/armored-witness#253

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 33.69%. Comparing base (3c58af4) to head (fcb548b).
Report is 72 commits behind head on main.

Files Patch % Lines
internal/feeder/bastion/bastion_feeder.go 0.00% 5 Missing ⚠️
omniwitness/omniwitness.go 0.00% 3 Missing ⚠️
cmd/omniwitness/monolith.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #233       +/-   ##
===========================================
- Coverage   51.05%   33.69%   -17.36%     
===========================================
  Files          11       23       +12     
  Lines         903     1365      +462     
===========================================
- Hits          461      460        -1     
- Misses        374      810      +436     
- Partials       68       95       +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlCutter AlCutter merged commit 1bc742f into transparency-dev:main Jun 25, 2024
8 checks passed
@AlCutter AlCutter deleted the bastion_governor branch June 25, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants