Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire up bastion rate limit #316

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Wire up bastion rate limit #316

merged 4 commits into from
Jun 25, 2024

Conversation

AlCutter
Copy link
Collaborator

@AlCutter AlCutter commented Jun 25, 2024 •
edited
Loading

This PR enables the bastion feeder rate limit support in the AW applet.

I0625 14:48:52.012078   55749 main.go:148] (77ms/77ms) transparency.dev/armored-witness/firmware_transparency/ci/2: 429 Too Many Requests:
I0625 14:48:52.012106   55749 main.go:148] (77ms/77ms) transparency.dev/armored-witness/firmware_transparency/prod/1: 429 Too Many Requests:
I0625 14:48:52.012172   55749 main.go:148] (79ms/79ms) Armory Drive Prod 2: 429 Too Many Requests:
I0625 14:48:52.012274   55749 main.go:148] (79ms/79ms) transparency.dev/armored-witness/firmware_transparency/ci/3: 200 OK: — DEV:ArmoredWitness-misty-snow TrDK0riwemYAAAAA6+PfIdN88T6c/rNnxeWYiE5lXUP65wmdOQX6yF93VPM7t8psf1/S9NcOMygfqUkonWHVdumdEgg7WIOPmhDoAw==
I0625 14:48:52.015356   55749 main.go:148] (54ms/54ms) go.sum database tree: 429 Too Many Requests:
I0625 14:48:52.050240   55749 main.go:148] (5ms/5ms) rekor.sigstore.dev - 3904496407287907110: 429 Too Many Requests:
I0625 14:48:52.058169   55749 main.go:148] (5ms/5ms) rekor.sigstore.dev - 2605736670972794746: 429 Too Many Requests:
I0625 14:48:52.082622   55749 main.go:148] (5ms/5ms) lvfs: 429 Too Many Requests:
I0625 14:48:52.088858   55749 main.go:148] (10ms/10ms) developers.google.com/android/binary_transparency/0: 429 Too Many Requests:
I0625 14:48:52.938278   55749 main.go:148] (6ms/6ms) transparency.dev/armored-witness/firmware_transparency/prod/1: 429 Too Many Requests:
I0625 14:48:53.009942   55749 main.go:148] (77ms/77ms) Armory Drive Prod 2: 200 OK: — DEV:ArmoredWitness-misty-snow TrDK0rawemYAAAAAnwwNMECjcEfCdGGcnN5/xBBOT2dBJblfYIgu36RGpwIr0iw9ytfg8rKJZyNkgKumGmlRXQ/6fielbilyfFKXBQ==
I0625 14:48:53.013715   55749 main.go:148] (80ms/80ms) transparency.dev/armored-witness/firmware_transparency/ci/2: 429 Too Many Requests:
I0625 14:48:53.013770   55749 main.go:148] (81ms/81ms) transparency.dev/armored-witness/firmware_transparency/ci/3: 429 Too Many Requests:
I0625 14:48:53.014612   55749 main.go:148] (55ms/55ms) go.sum database tree: 429 Too Many Requests:

Towards transparency-dev/armored-witness#253

@AlCutter AlCutter marked this pull request as ready for review June 25, 2024 14:00
mhutchinson
mhutchinson approved these changes Jun 25, 2024
View reviewed changes
trusted_applet/main.go Outdated
@@ -360,6 +363,8 @@ func runWithNetworking(ctx context.Context) error {
klog.Infof("Bastion host %q configured", BastionAddr)
opConfig.BastionAddr = BastionAddr
opConfig.BastionKey = bastionSigningKey
opConfig.BastionRateLimit = bastionRateLimit

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this extra line

@AlCutter AlCutter merged commit c7a83db into transparency-dev:main Jun 25, 2024
3 checks passed
@AlCutter AlCutter deleted the bastion_rate_limit branch June 25, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhutchinson mhutchinson mhutchinson approved these changes

Assignees

@mhutchinson mhutchinson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlCutter @mhutchinson