Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPL-283] Add Disable Jobs Property #213

Merged
merged 11 commits into from
Nov 27, 2024
+38 −7
Merged

[CPL-283] Add Disable Jobs Property #213

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e416c56
add disable jobs property
yijun-lin Nov 22, 2024
134f8da
add disable jobs property
yijun-lin Nov 22, 2024
9ef0071
add flag to disable task cleaner and resumer
yijun-lin Nov 22, 2024
a0a521e
disable task resumer and cleaner at application startup
yijun-lin Nov 22, 2024
fec1ee5
add new flag for task resumer
yijun-lin Nov 25, 2024
1592770
add new flag for task resumer
yijun-lin Nov 25, 2024
d63e941
remove unused imports
yijun-lin Nov 25, 2024
465459f
reword java doc
yijun-lin Nov 25, 2024
35e7bfa
quick fix
yijun-lin Nov 26, 2024
75f9460
quick fix
yijun-lin Nov 26, 2024
256d782
update changelog and bump version
yijun-lin Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tw-tasks-jobs-test/src/main/java/com/transferwise/tasks/impl/jobs/test/TestJobsService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ public boolean hasFinished(ExecuteAsyncHandle handle) {
public void reset() {
transactionsHelper.withTransaction().asNew().call(() -> {
testTasksService.reset();
initJobs(true);
if (jobsProperties.isAutoStartProcessing()) {
initJobs(true);
}
return null;
});
}
Expand Down
2 changes: 2 additions & 0 deletions tw-tasks-jobs/src/main/java/com/transferwise/tasks/impl/jobs/JobsProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,6 @@ public class JobsProperties {
private String processingBucket = IBucketsManager.DEFAULT_ID;

private boolean testMode = false;

private boolean autoStartProcessing = true;
yijun-lin marked this conversation as resolved.
Show resolved Hide resolved
}
6 changes: 4 additions & 2 deletions tw-tasks-jobs/src/main/java/com/transferwise/tasks/impl/jobs/JobsService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public class JobsService implements IJobsService, GracefulShutdownStrategy, Init
@Autowired
private ITasksService tasksService;
@Autowired
private JobsProperties jobsProperties;
protected JobsProperties jobsProperties;
@Autowired
private ApplicationContext applicationContext;
@Autowired(required = false)
Expand All @@ -60,7 +60,9 @@ public void afterPropertiesSet() {

@Override
public void applicationStarted() {
initJobs(false);
if (jobsProperties.isAutoStartProcessing()) {
initJobs(false);
}
}

@Override
Expand Down
Loading