Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPL-283] Add Disable Jobs Property #213

Merged
merged 11 commits into from
Nov 27, 2024
Merged

[CPL-283] Add Disable Jobs Property #213

merged 11 commits into from
Nov 27, 2024
+38 −7

Conversation

yijun-lin
Copy link
Contributor

@yijun-lin yijun-lin commented Nov 22, 2024 •
edited
Loading

Context

While implementing maintenance mode for payout service, we notice that there isn't a flag for enable/disable Jobs.

This PR:

  • add disable job property
  • stops register and resuming Jobs when disabled
  • add new property for task cleaner
  • use existing autoStartProcessing for enable / disable task resumer

Checklist

@yijun-lin yijun-lin marked this pull request as ready for review November 22, 2024 14:43
@yijun-lin yijun-lin requested a review from a team as a code owner November 22, 2024 14:43
maru-tw
maru-tw reviewed Nov 22, 2024
View reviewed changes
Copy link

@maru-tw maru-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it a concious decision to split the disabling of jobs and tasks?

Is there an option of one parameter to be set that would "halt" processing for all tasks, jobs?

tw-tasks-core/src/main/java/com/transferwise/tasks/TasksProperties.java Outdated Show resolved Hide resolved
@yijun-lin yijun-lin changed the title add disable jobs property [CPL-283] Add Disable Jobs Property Nov 25, 2024
@yijun-lin yijun-lin merged commit c3ceb1d into master Nov 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronrosser aaronrosser aaronrosser left review comments

@evsan-tw evsan-tw evsan-tw left review comments

@maru-tw maru-tw maru-tw left review comments

@onukristo onukristo onukristo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yijun-lin @onukristo @maru-tw @evsan-tw @aaronrosser