Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to manifest v3 #156

Closed
Tracked by #147
MrMamen opened this issue Apr 19, 2022 · 2 comments · Fixed by #256
Closed
Tracked by #147

Update to manifest v3 #156

MrMamen opened this issue Apr 19, 2022 · 2 comments · Fixed by #256
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@MrMamen
Copy link
Member

MrMamen commented Apr 19, 2022

Manifest v2 is deprecated and no longer accepted for releases:
https://developer.chrome.com/blog/mv2-transition/

This rewrite is required for #147

@rafaelgomesxyz
Copy link
Member

This will be a bit of a problem because of how we use the background page at the moment, but I'll try to figure something out.

@rafaelgomesxyz rafaelgomesxyz self-assigned this May 23, 2022
@MrMamen MrMamen added this to the v1.0.0 milestone Sep 14, 2022
@rafaelgomesxyz
Copy link
Member

rafaelgomesxyz commented Oct 1, 2022

Will try to tackle this. From an initial observation, this is what needs to be done:

  • General changes to the manifest file. These will probably not be that difficult, as it's mostly renaming things and moving things around.
  • Adapt any logic that required the background page to stay active (service workers go inactive after a while). Most of this is probably achievable by storing the data with browser.storage and then getting it when needed. Major refactor.
  • Adapt script injections to use scripting.executeScript. Small refactor.
  • Adapt any code that ran in intervals to use browser.alarms (like auto sync and cache checks running every hour). Small refactor.
  • Adapt usages of webRequest to the new declarativeNetRequest. This one might be the more annoying one, but since webRequest is only used for Firefox, and only when using containers, I might just ignore it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants