Make compatible with Manifest v3

[rafaelgomesxyz]

Fixes #156

NOTE: This should be carefully tested, as some things might still be broken. I'll continue to test on my end throughout this week.

This follows Chrome's migration guide and:

• changes manifest version to v3
• changes background script to service worker
• separates permissions from host permissions
• removes content security policy
• renames browser action to action
• removes web accessible resources
• uses scripting API to inject content scripts
• uses scripting API to inject functions (all functions that need to be injected now have to be added to Shared.functionsToInject on first run, because they need to be accessible from the service worker)
• removes ports, as they're not compatible with service workers (the new method to identify when a content script has connected is to send a message to the service worker, and the new method to identify when a content script has disconnected is to add a listener to browser.tabs.onRemoved)
• removes axios, as XMLHttpRequest isn't compatible with service workers (rate limiting has been removed as well, but our requests are already sequential, so they shouldn't cause many issues)
• removes window/document references from background logic, as they're not available in service workers

There might be other changes that need to be made.

These changes should be fully backwards compatible with manifest v2. Webpack is configured to build v2 for Firefox and v3 for Chrome, as v3 isn't accepted in the Firefox store yet, as far as I could tell.

[rafaelgomesxyz]

@MrMamen It's a WIP, but if you already want to take a look.

[rafaelgomesxyz]

@MrMamen Can we try to land this? I didn't test too much (also mostly just Netflix), but we can always refine it later. I'd like to release it on Chrome soon.

[MrMamen]

Yes. I'll test it a bit.

[MrMamen]

NRK doesn't work with scrobbeling. This is due to the injection script not working. (Only tested on Chrome).

[rafaelgomesxyz]

Got it, thanks, I'll see if I can fix it.

[rafaelgomesxyz]

@MrMamen Script injection for functions should be fixed.

[MrMamen]

@MrMamen Script injection for functions should be fixed.

It seems to me that the scrobbling part needed to be disabled and re-enabled after switching to this branch. (for NRK at least.) If there is no way to prevent this, perhaps the migrate script should simply disable the scrobbling for injection-script sites?

[rafaelgomesxyz]

@MrMamen Script injection for functions should be fixed.

It seems to me that the scrobbling part needed to be disabled and re-enabled after switching to this branch. (for NRK at least.) If there is no way to prevent this, perhaps the migrate script should simply disable the scrobbling for injection-script sites?

But that's for Chrome, right? I don't think it will be possible to migrate from v2 to v3 on Chrome, because they have different IDs, so they should be two separate extensions when installed. That wasn't the case for you because you probably don't have the ID configured in your .env. Unfortunately, I think Chrome users will have to reconfigure their options.

[rafaelgomesxyz]

I'll see if I can add an import/export functionality to allow users to move their data.

[MrMamen]

I'll see if I can add an import/export functionality to allow users to move their data.

Om not sure how important this is. More important to get this to shipped. We should be more careful with these things after it hits the Web Stores.

[rafaelgomesxyz]

Ok, I've actually already uploaded it to the Chrome store because I wanted to test something: https://chrome.google.com/webstore/detail/universal-trakt-scrobbler/mbhadeogepkjdjeikcckdkjdjhhkhlid

But before we add it to the README I want to land another PR that I'll open later today that allows users to do a full initial sync.

[MrMamen]

I experience that at least netflix history keeps loading/spinning forever, with no obvious error..

[MrMamen]

Looks good to me.