Skip to content

Build in memory if temp_dir is not given. #127

Build in memory if temp_dir is not given.

Build in memory if temp_dir is not given. #127

GitHub Actions / clippy succeeded Nov 15, 2024 in 0s

clippy

11 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 11
Note 0
Help 0

Versions

  • rustc 1.84.0-nightly (90ab8eaed 2024-11-14)
  • cargo 1.84.0-nightly (4a2d8dc63 2024-11-09)
  • clippy 0.1.84 (90ab8eaedd 2024-11-14)

Annotations

Check warning on line 287 in src/cli/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `MapOpts` which implements the `Copy` trait

warning: using `clone` on type `MapOpts` which implements the `Copy` trait
   --> src/cli/main.rs:287:56
    |
287 |                     res.append(&mut kbo::map(ref_contig, &sbwt, &lcs, map_opts.clone()));
    |                                                                       ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `map_opts`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Check warning on line 212 in src/cli/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `usize` which implements the `Copy` trait

warning: using `clone` on type `usize` which implements the `Copy` trait
   --> src/cli/main.rs:212:13
    |
212 | ...                   ref_bases.clone()
    |                       ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*ref_bases`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Check warning on line 208 in src/cli/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `FindOpts` which implements the `Copy` trait

warning: using `clone` on type `FindOpts` which implements the `Copy` trait
   --> src/cli/main.rs:208:73
    |
208 |                         res.append(&mut kbo::find(&seq.reverse_complement(), &sbwt, &lcs, find_opts.clone())
    |                                                                                           ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `find_opts`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Check warning on line 208 in src/cli/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/cli/main.rs:208:67
    |
208 |                         res.append(&mut kbo::find(&seq.reverse_complement(), &sbwt, &lcs, find_opts.clone())
    |                                                                                     ^^^^ help: change this to: `lcs`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 208 in src/cli/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/cli/main.rs:208:60
    |
208 |                         res.append(&mut kbo::find(&seq.reverse_complement(), &sbwt, &lcs, find_opts.clone())
    |                                                                              ^^^^^ help: change this to: `sbwt`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 204 in src/cli/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `usize` which implements the `Copy` trait

warning: using `clone` on type `usize` which implements the `Copy` trait
   --> src/cli/main.rs:204:13
    |
204 | ...                   ref_bases.clone()
    |                       ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*ref_bases`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Check warning on line 200 in src/cli/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `FindOpts` which implements the `Copy` trait

warning: using `clone` on type `FindOpts` which implements the `Copy` trait
   --> src/cli/main.rs:200:52
    |
200 |                         res.append(&mut kbo::find(&seq, &sbwt, &lcs, find_opts.clone())
    |                                                                      ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `find_opts`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
    = note: `#[warn(clippy::clone_on_copy)]` on by default

Check warning on line 200 in src/cli/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/cli/main.rs:200:46
    |
200 |                         res.append(&mut kbo::find(&seq, &sbwt, &lcs, find_opts.clone())
    |                                                                ^^^^ help: change this to: `lcs`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 200 in src/cli/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/cli/main.rs:200:39
    |
200 |                         res.append(&mut kbo::find(&seq, &sbwt, &lcs, find_opts.clone())
    |                                                         ^^^^^ help: change this to: `sbwt`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 506 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `f64` which implements the `Copy` trait

warning: using `clone` on type `f64` which implements the `Copy` trait
   --> src/lib.rs:506:33
    |
506 |     match_opts.max_error_prob = find_opts.max_error_prob.clone();
    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `find_opts.max_error_prob`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
    = note: `#[warn(clippy::clone_on_copy)]` on by default

Check warning on line 506 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field assignment outside of initializer for an instance created with Default::default()

warning: field assignment outside of initializer for an instance created with Default::default()
   --> src/lib.rs:506:5
    |
506 |     match_opts.max_error_prob = find_opts.max_error_prob.clone();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: consider initializing the variable with `MatchOpts { max_error_prob: find_opts.max_error_prob.clone() }` and removing relevant reassignments
   --> src/lib.rs:505:5
    |
505 |     let mut match_opts = MatchOpts::default();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
    = note: `#[warn(clippy::field_reassign_with_default)]` on by default