-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BPF] fix VLAN not supported docs #1742
Draft
tomastigera
wants to merge
1
commit into
tigera:main
Choose a base branch
from
tomastigera:tomas-bpf-vlan-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[1] Seems this changes it to a limitation, no? eBPF supports VLAN-based traffic, but only in the following circumstances: etc.
[2] How does this relate to a no-support statement we have elsewhere for "Tagged VLAN devices"? (see here)
[3] I don't understand the details in this addition. Best I can figure, you can't generally use VLAN, but if you configure it right (with
bpfDataIfacePattern
) you can have a particular node connect to the cluster with a VLAN device. I don't get the bit about main non-vlan or the bond stuff. Are those workarounds?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[1] - idk if it is just a limitation or whether that is how you always need to set it up
[2] it is the same change for other places, but but I want to hash out a version first
[3] yes you need to configure it, wan't work out of the box. I think that is the limitation, but @sridhartigera is working on it. The bond stuff is not a workaround, that is how it should work.https://docs.google.com/document/d/1RNHRR39TNl0LXYt5tad14lI72ZFl3g5mDzmhQ3Qe6CM/edit?usp=sharing